Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option for Custom Escape Character #28

Merged
merged 3 commits into from Oct 8, 2015

Conversation

galenandrew
Copy link
Contributor

Added option for custom escape character to allow for more flexibility. The value defaults to " so that it's not a breaking change.

I did rename the variables from quote to escape to be more semantically correct (e.g. you would "escape" a quote by adding an escape character in front of it). Since you are the maintainer of this project I will fall back to your naming convention preference here. Let me know if you disagree/dislike escape, _escaped, and isEscaped and I'll change them back to be quote-based variable names.

NOTE: It's not perfect as it assumes the character being escaped and the escape character are the same. For example it does not allow this: "some \"column\" value" (the escape character being \ in this scenario). I feel that this type of change is more significant to the core functionality and would require it's own Pull Request.

mafintosh added a commit that referenced this pull request Oct 8, 2015
Add Option for Custom Escape Character
@mafintosh mafintosh merged commit d3f5f68 into mafintosh:master Oct 8, 2015
@galenandrew galenandrew deleted the customEscapeCharacter branch October 8, 2015 21:14
@mafintosh
Copy link
Owner

This is a really good PR. Both from a description standpoint, to tests, and to the implementation. Great job! Released in 1.8.0

@galenandrew
Copy link
Contributor Author

Thanks @mafintosh…happy to give back! Also, thank you for the quick merge/release!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants