Add Option for Custom Escape Character #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option for custom escape character to allow for more flexibility. The value defaults to
"
so that it's not a breaking change.I did rename the variables from
quote
toescape
to be more semantically correct (e.g. you would "escape" a quote by adding an escape character in front of it). Since you are the maintainer of this project I will fall back to your naming convention preference here. Let me know if you disagree/dislikeescape
,_escaped
, andisEscaped
and I'll change them back to be quote-based variable names.NOTE: It's not perfect as it assumes the character being escaped and the escape character are the same. For example it does not allow this:
"some \"column\" value"
(the escape character being\
in this scenario). I feel that this type of change is more significant to the core functionality and would require it's own Pull Request.