Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some glaring issues reported by eslint in test.js. #19

Merged
merged 1 commit into from Jan 11, 2018
Merged

Fix some glaring issues reported by eslint in test.js. #19

merged 1 commit into from Jan 11, 2018

Conversation

@pusateri
Copy link
Contributor

@pusateri pusateri commented Jan 11, 2018

variables i, code used outside binding context. (block-scoped-var) /* I introduced these /
'packet' is already declared in the upper scope. (no-shadow) /
this one was causing me trouble */
Does anyone want to contribute an .eslintrc ?
I generated one based on index.js and test.js failed miserably. I will volunteer to fix others too if desired.

@silverwind
Copy link
Collaborator

@silverwind silverwind commented Jan 11, 2018

Thanks!

I think I will work on integrating my config (making adjustments where necessary), if no one objects.

@silverwind silverwind closed this Jan 11, 2018
@silverwind silverwind reopened this Jan 11, 2018
@silverwind silverwind merged commit 81d4a96 into mafintosh:master Jan 11, 2018
1 check was pending
@silverwind
Copy link
Collaborator

@silverwind silverwind commented Jan 11, 2018

ESLint added in 3632f18.

@pusateri pusateri deleted the eslint branch Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants