Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SSHFP records #80

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Implement SSHFP records #80

merged 2 commits into from
Jun 14, 2022

Conversation

wolfy1339
Copy link
Contributor

No description provided.

Use offset since we may receive a full dns packet
Account for maximum hash lengths for each hash type
fix: don't use the output of `Buffer#copy()`, instead use `Buffer#byteLength`
fix: normalize fingerprint string
fix: the offset pointer starts out at RDLENGTH
fix: account for the `RDLENGTH` field in `rsshfp.decode()`
@silverwind silverwind merged commit fab30b2 into mafintosh:master Jun 14, 2022
@wolfy1339 wolfy1339 deleted the sshfp branch June 14, 2022 21:09
martinheidegger pushed a commit to dnsquery/dns-packet that referenced this pull request Dec 2, 2022
* Add SSHFP record support

Use offset since we may receive a full dns packet
Account for maximum hash lengths for each hash type
fix: don't use the output of `Buffer#copy()`, instead use `Buffer#byteLength`
fix: normalize fingerprint string
fix: the offset pointer starts out at RDLENGTH
fix: account for the `RDLENGTH` field in `rsshfp.decode()`

* tests: add test for the SSHFP record type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants