New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reminder that the onwrite handler has to call cb() #190

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
3 participants
@aral
Copy link
Contributor

aral commented Jan 17, 2019

This was not immediately clear to me and my appends were not working without it.

Add reminder that the onwrite handler has to call cb()
This was not immediately clear to me and my appends were not working without it.
@martinheidegger

This comment has been minimized.

Copy link
Contributor

martinheidegger commented Jan 17, 2019

Maybe also rename the argument to next or nextCb?

@aral

This comment has been minimized.

Copy link
Contributor Author

aral commented Jan 17, 2019

@martinheidegger 👍 next would make it clearer that this works like middleware. I would not have been confused if that’s what it had been called in the docs.

Would prefer that to my note in the docs ;)

@mafintosh mafintosh merged commit b5fddfb into mafintosh:master Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment