New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting type: 'directory' doesnt override mode #16

Closed
maxogden opened this Issue Jan 5, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@maxogden
Collaborator

maxogden commented Jan 5, 2016

i think this is the code

if (!file.mode) file.mode = file.type === 'directory' ? octal(755) | constants.S_IFDIR : octal(644)

if i write this entry on one side:

{ name: 'folder',
  mode: 16877,
  uid: 501,
  gid: 20,
  mtime: 1452023306000,
  ctime: 1452023306000,
  type: 'directory' }

i get this on the other side:

{ type: 'file',
  value: 
   { name: 'folder',
     mode: 16877,
     size: 0,
     uid: 501,
     gid: 20,
     mtime: 1452023306000,
     ctime: 1452023306000 },
  link: null }

its a folder on disk, im not sure why its treating it as a file here

@mafintosh mafintosh closed this in 3d58186 Jan 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment