Standard #15
Closed
Standard #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,23 +44,31 @@ if (cmd === 'listen') { | |||
| server.listen(argv.port, argv.host, function () { | |||
| console.log('signalhub listening on port %d', server.address().port) | |||
| }) | |||
| return | |||
| process.exit(0) | |||
There was a problem hiding this comment.
this unfortunately won't work since that kills the process and therefor the server :(
|
maybe just wrap that code in a function so standard doesnt complain about it? |
|
Not supporting |
perguth
added a commit
to perguth/signalhub
that referenced
this pull request
Jan 5, 2016
|
Yes, looks better @maxogden! |
|
Whops. Closed by accident. But IIFE sucked anyway^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.