Mathias Buus mafintosh

Organizations

@Level @nodeschool @datproject @nodejs @webrtcftw @ipfs @moose-team
@mafintosh

:+1:

mafintosh commented on pull request mafintosh/prebuild#15
@mafintosh

you should put this one in a module

mafintosh commented on pull request mafintosh/prebuild#15
@mafintosh

shouldn't this check if it contains APPDATA?

mafintosh commented on pull request mafintosh/prebuild#15
@mafintosh

don't try-catch the cb() call. we might end up calling cb twice when doing this

mafintosh commented on pull request mafintosh/prebuild#15
@mafintosh

:+1: for squashing

@mafintosh

actually looking at the way you use --cwd i think you just wanna use the old --path arg and remove (or alias) cwd. (https://github.com/mafintosh/pr…

@mafintosh

:+1:

@mafintosh

we already have --path which changes the project cwd. maybe we could call this something else so its a bit less similar? --download-path maybe?

mafintosh commented on issue mafintosh/messages#1
@mafintosh

Yea! As long as you link it here when you have something working. On Fri 31 Jul 2015 at 15:25 Ivo Georgiev notifications@github.com wrote: I am pl…

mafintosh commented on issue maxogden/dat#365
@mafintosh

Interesting... This is probably related to the multiprocess stuff. I'll try to reproduce

mafintosh commented on issue mafintosh/prebuild#13
@mafintosh

yea that's probably better. then we could support --pkg-name and other ones as well

mafintosh commented on issue mafintosh/prebuild#14
@mafintosh

possibly related, TooTallNate/node-gyp#652

mafintosh commented on issue mafintosh/prebuild#13
@mafintosh

if the version flag has a value we could use it in the naming of the prebuild. and if it doesn't it would print out the prebuild version.

mafintosh commented on issue mafintosh/prebuild#13
@mafintosh

:+1: ... we use --version to print out the prebuild version now though but we should support this

@mafintosh
@mafintosh
mafintosh created branch master at mafintosh/messages
mafintosh created repository mafintosh/messages
mafintosh commented on pull request mafintosh/prebuild#11
@mafintosh

This is great!

@mafintosh
mafintosh merged pull request mafintosh/prebuild#11
@mafintosh
update README with more info on --download and some extra stuff
1 commit with 77 additions and 21 deletions
mafintosh commented on pull request mafintosh/hyperlog#7
@mafintosh

Maybe .publicKey should be renamed to .identity? That probably indicates better this could also be a hash of a public key fx. @substack thoughts?