Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backbone to 1.2.x and consider new "update" collection event #82

Closed
darky opened this issue Jun 21, 2015 · 8 comments
Closed

Update backbone to 1.2.x and consider new "update" collection event #82

darky opened this issue Jun 21, 2015 · 8 comments

Comments

@darky
Copy link
Contributor

darky commented Jun 21, 2015

No description provided.

@magalhas
Copy link
Owner

I can do this but meanwhile feel free to open a PR for it, it looks like pretty straightforward changes 👍 Thank you for opening the issue

@darky
Copy link
Contributor Author

darky commented Jul 2, 2015

Close this, because this kill backbone <1.2.0 compatibility

@darky darky closed this as completed Jul 2, 2015
@magalhas
Copy link
Owner

magalhas commented Jul 3, 2015

@Darrrk can you please elaborate why does the compatibility breaks? I'm going to reopen the issue for the sake of this discussion. Thank you!

@magalhas magalhas reopened this Jul 3, 2015
@darky
Copy link
Contributor Author

darky commented Jul 3, 2015

Since backbone 1.2.0 you can use update event instead add and remove
Pros:
We can use only one update event instead any amount of multiple add or/and remove events.
Negative:
Breaks compatibility with backbone less than 1.2.0

@magalhas
Copy link
Owner

magalhas commented Jul 3, 2015

I don't see why this change couldn't be included in the incoming version of this lib. React also includes some breaking changes in some versions and we'll keep up with it, I guess the same approach applies do Backbone. If the dev needs, simply lock backbone-react-component to the minor version (0.8 in this case).

Do you agree?

Cumprimentos,
José Magalhães

On Fri, Jul 3, 2015 at 11:18 AM, Vladislav Botvin
notifications@github.com wrote:

Since backbone 1.2.0 you can use update event instead add and remove
Pros:
We can use only one update event instead any amount of multiple add or/and remove events.
Negative:

Breaks compatibility with backbone less than 1.2.0

Reply to this email directly or view it on GitHub:
#82 (comment)

@darky
Copy link
Contributor Author

darky commented Jul 3, 2015

Ok, giving PR

@magalhas
Copy link
Owner

magalhas commented Jul 3, 2015

Sweet 👍

@darky
Copy link
Contributor Author

darky commented Jul 3, 2015

#85 merged

@darky darky closed this as completed Jul 3, 2015
@magalhas magalhas mentioned this issue Jul 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants