Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 947 #1855

Merged
merged 15 commits into from Nov 15, 2018
Merged

Issue 947 #1855

merged 15 commits into from Nov 15, 2018

Conversation

mwu2018
Copy link
Contributor

@mwu2018 mwu2018 commented Nov 12, 2018

What this PR does

Fixes #947

Checklist

  • There are unit tests to verify my changes are correct.
  • I've updated CHANGES.md with what I changed.
  • I've linked this PR to an issue in ZenHub (core dev team only)

Copy link
Contributor

@AlexGilleran AlexGilleran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike! Looks pretty good, I'd just like the intentions of the tests to be worded a bit differently :).

Also don't forget to add yourself to contributors.md!

magda-ckan-connector/src/test/CkanTransformer.spec.ts Outdated Show resolved Hide resolved
magda-ckan-connector/src/test/CkanTransformer.spec.ts Outdated Show resolved Hide resolved
magda-ckan-connector/src/CkanTransformer.ts Outdated Show resolved Hide resolved
magda-typescript-common/src/test/JsonTransformer.spec.ts Outdated Show resolved Hide resolved
@AlexGilleran
Copy link
Contributor

@mwu2018 I'm now up to testing this - once the docker container is built I'm getting this error on startup:

[14:29:58] magda-metadata (issue-947b) >kubectl logs -f connector-dga-n5jdg --namespace issue-947b
module.js:478
throw err;
^

Error: Cannot find module 'src/createTransformer'
    at Function.Module._resolveFilename (module.js:476:15)
    at Function.Module._load (module.js:424:25)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/usr/src/app/component/dist/setup.js:4:29)
    at Module._compile (module.js:577:32)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)

You can see this if you go to the issue-947b namespace on the dev cluster, ask me or @t83714 for access

@mwu2018
Copy link
Contributor Author

mwu2018 commented Nov 14, 2018

I will look into it.
I suspect that I need to change from
import createTransformer from "src/createTransformer";
to
import createTransformer from "./createTransformer";
in file
setup.ts

@mwu2018
Copy link
Contributor Author

mwu2018 commented Nov 14, 2018

The docker build error is now fixed.
Sorry, I should have run yarn docker-build-local to verify it.

Copy link
Contributor

@AlexGilleran AlexGilleran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlexGilleran AlexGilleran merged commit af9fcc2 into master Nov 15, 2018
@AlexGilleran AlexGilleran deleted the issue-947b branch November 15, 2018 04:04
@magdabot magdabot restored the issue-947b branch October 7, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants