New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 947 #1855
Issue 947 #1855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mike! Looks pretty good, I'd just like the intentions of the tests to be worded a bit differently :).
Also don't forget to add yourself to contributors.md
!
@mwu2018 I'm now up to testing this - once the docker container is built I'm getting this error on startup: [14:29:58] magda-metadata (issue-947b) >kubectl logs -f connector-dga-n5jdg --namespace issue-947b
You can see this if you go to the |
I will look into it. |
The docker build error is now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What this PR does
Fixes #947
Checklist