Skip to content

Allow configuring which page is supported via DI type #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jissereitsma wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow configuring which page is supported via DI type #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions Helper/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use Magento\Framework\App\Helper\Context;
use Magento\Framework\App\State;
use Magento\Framework\App\RequestInterface;
use Magento\Framework\Exception\LocalizedException;

class Config extends AbstractHelper {

Expand All @@ -18,6 +19,7 @@ class Config extends AbstractHelper {
* @var State
*/
protected State $state;
private array $allowModuleNames;

/**
* @param Context $context
Expand All @@ -27,28 +29,28 @@ class Config extends AbstractHelper {
public function __construct(
Context $context,
RequestInterface $request,
State $state
State $state,
array $allowModuleNames = []
) {
$this->request = $request;
$this->state = $state;
return parent::__construct($context);
$this->allowModuleNames = $allowModuleNames;
parent::__construct($context);
}

public function optimizeRequireJsConfig() {
try {
$areaCode = $this->state->getAreaCode();
} catch (\Magento\Framework\Exception\LocalizedException $e) {
$areaCode = 'cli';
} catch (LocalizedException $e) {
return true;
}

if (
$areaCode === 'cli' ||
$areaCode === 'frontend' &&
($this->request->getModuleName() === "cms" || $this->request->getModuleName() === "catalog")
if ($areaCode === 'frontend'
&& in_array($this->request->getModuleName(), $this->allowModuleNames)
) {
return true;
}

return false;
}

}
8 changes: 8 additions & 0 deletions etc/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,12 @@
<type name="Magento\Framework\RequireJs\Config">
<plugin name="use-optimized-requirejs-build" type="MageOS\RequireJsOptimizer\Plugin\ChangeRequireJsConfig" />
</type>
<type name="MageOS\RequireJsOptimizer\Helper\Config">
<arguments>
<argument name="allowModuleNames" xsi:type="array">
<item name="cms" xsi:type="string">cms</item>
<item name="catalog" xsi:type="string">catalog</item>
</argument>
</arguments>
</type>
</config>