Rollbacks may be bugged

[spjspj]

1.4.13v1 may have introduced bugs with rollbacks. Possible changes that I can think of that broke it were the shrinking of the panel sizes (possible??) or possibly the Ctrl+Click (unlikely)

[dylan1020]

Rollbacks seem to be bugged right now. It doesn't roll back everything (like creatures no longer attacking and creatures that have died)

[spjspj]

fd60e43 may have something to do with it.

[drmDev]

Another report on the forums regarding it:
"Rollback glitch when playing opponent (human NOT AI).
Person passed the turn, I had end step selected and it rolled right through my turn to the end and went to my opponent's turn. He then selected rollback to start of previous turn. It went back to the start of my turn, after my turn was over it skipped his turn and gave me another turn.

This has now happened with two different opponent's with at least one of us being skipped after a rollback occurs."

[drmDev]

Another report on reddit:
"I've encountered a very situational bug regarding Flagstones of Trokair. I cast Smallpox and sacced Flagstones of Trokair, but before the flagstones trigger resolved, my opponent requested a rollback. I accepted and when the rollback happened, my Flagstones was gone and the trigger was still on the stack, however, the computer didn't allow either of us to have priority."

[drmDev]

With Emrakul, the Promised End: "If you roll back once or twice during your opponent's controlled turn, the opponent will not get an extra turn for some reason. " #2168

[LevelX2]

Creature that dies during combat was not returned to battlefield after rollback to start of current turn after the combat..

[quercitron]

Could not reproduce locally any of rollback bugs using a trivial scenario (some creatures die, then rollback to the current/previous turn start). Any suggestions how it can be reproduced?

[LevelX2]

https://www.reddit.com/r/XMage/comments/638dnk/rollback_glitch_fix/

[tebo37]

Bump - this is definitely still happening. Upon rolling back, one player is unable to obtain priority ever again until the game ends. The reddit trick posted above did not work for us after 30+ attempts.

[JayDi85]

How to fix: remove all changeable data from GameImpl to GameState:

Suspicious data from GameImpl (can be moved to GameState, but need research):

• checkPlayableState
• lki
• lkiCardState
• lkiExtended
• shortLivingLKI
• saveGame - not used
• permanentsEntering
• losingPlayer
• stateCheckRequired - outdated and not used
• infiniteLoopCounter -- infinite loop check
• lastNumberOfAbilitiesOnTheStack -- infinite loop check
• lastPlayersLifes -- infinite loop check
• stackObjectsCheck -- infinite loop check
• enterWithCounters
• concedingPlayers