Skip to content

/ mage

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declaration in Stone does not allow the exile of more than one creature with the same name. #3017

Closed
drmDev opened this issue Mar 23, 2017 · 4 comments
Closed

Declaration in Stone does not allow the exile of more than one creature with the same name. #3017

drmDev opened this issue Mar 23, 2017 · 4 comments
Labels
bug not confirmed

Comments

@drmDev
Copy link
Contributor

@drmDev drmDev commented Mar 23, 2017

Declaration in stone does not allow the exile of more than one creature with the same name.

(from forums)

escplan9: We've multiple bugs with Declaration in Stone recently as well as fixes for them. Do we not have many unit tests on these?
drmDev added a commit to drmDev/mage that referenced this issue Mar 24, 2017
@drmDev
magefree#3017 unit tests for declaration in stone. cannot duplicate i…
94c8d7f 
…ssue
drmDev added a commit that referenced this issue Mar 24, 2017
@drmDev
Merge pull request #3019 from drmDev/ut/dec-stone
aab2eb8 
#3017 unit tests for declaration in stone. cannot duplicate issue
@drmDev
Copy link
Contributor Author

@drmDev drmDev commented Mar 24, 2017

Cannot duplicate with unit tests. Will need to test manually. Close if unable to reproduce.
@ingmargoudt
Copy link
Contributor

@ingmargoudt ingmargoudt commented Mar 24, 2017

I see that Declaration in Stone uses a Set of Cards. Should this perhaps be a list instead?
@emerald000
Copy link
Contributor

@emerald000 emerald000 commented Mar 24, 2017

Unless two UUIDs happen to collide (1/2^122), a set will work as well as a list.
@drmDev
Copy link
Contributor Author

@drmDev drmDev commented Mar 25, 2017

Tested manually as well, works as expected. Closing - cannot duplicate manually or through automation.
@drmDev drmDev closed this Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug not confirmed
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@ingmargoudt @emerald000 @drmDev