Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game of Chaos bug #3022

Closed
drmDev opened this issue Mar 25, 2017 · 4 comments
Closed

Game of Chaos bug #3022

drmDev opened this issue Mar 25, 2017 · 4 comments

Comments

@drmDev
Copy link
Contributor

@drmDev drmDev commented Mar 25, 2017

Game of Chaos seems to be broken. I'm not sure exactly how the problem works but it looks like whoever wins the first toss will win all subsequent tosses. I've seen this happen twice in multiplayer EDH games.

(from forums)

http://gatherer.wizards.com/Pages/Card/Details.aspx?name=game%20of%20chaos

@drmDev
Copy link
Contributor Author

@drmDev drmDev commented Mar 25, 2017

I was pretty sure it was me who coded that card. Looking back at it 🙈 would not be surprised at all if there's a bug in there somewhere!

@drmDev
Copy link
Contributor Author

@drmDev drmDev commented Mar 25, 2017

I know it worked originally when I committed the card. Code ideally should be:

  1. Fixed bug
  2. Refactor the code for easier maintainability
  3. Make sure the message of who won/lost is displayed in the game.
@drmDev
Copy link
Contributor Author

@drmDev drmDev commented Mar 25, 2017

In testing this more, from what I'm seeing, it is not true that the winner of the first flip will always win them all. That will happen sometimes due to probabilities. Difficult card to test extensively. Not sure if I can unit test this.

@ingmargoudt
Copy link
Contributor

@ingmargoudt ingmargoudt commented Mar 25, 2017

In case you rewrite the code: turn it into a do-while loop ;)

@drmDev drmDev closed this in dcc8dc6 Mar 26, 2017
drmDev added a commit that referenced this issue Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants