Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combat Celebrant interaction #3195

Closed
ingmargoudt opened this issue Apr 20, 2017 · 9 comments
Closed

Combat Celebrant interaction #3195

ingmargoudt opened this issue Apr 20, 2017 · 9 comments

Comments

@ingmargoudt
Copy link
Contributor

@ingmargoudt ingmargoudt commented Apr 20, 2017

"Combat Celebrant is apparently bugged. I had two of them, swung both, exerted one to untap the rest and get another combat. Second combat, swing with the other celebrant, exert it to untap the rest and get another combat. Third combat, swing everything and I get to exert the one which had already been exerted this turn."

From forums : https://www.slightlymagic.net/forum/viewtopic.php?f=70&t=20440&sid=0a8b1786ac5a46578eb1e72e84af7401&start=45#p212001

Combat Celebrant might need an "IsExertedThisTurnWatcher" for this?

@ingmargoudt
Copy link
Contributor Author

@ingmargoudt ingmargoudt commented Apr 20, 2017

ah the watcher is internal to the ExertAbility, makes sense.

@drmDev
Copy link
Contributor

@drmDev drmDev commented Apr 20, 2017

add tests

@drmDev drmDev reopened this Apr 23, 2017
@drmDev
Copy link
Contributor

@drmDev drmDev commented Apr 23, 2017

Multiple users confirming this still is an issue. One mentioned possible interaction with Always Watching. Add unit tests.

@drmDev
Copy link
Contributor

@drmDev drmDev commented Apr 24, 2017

Actually cannot unit test this specific scenario due to UT Framework issues with cards having the same name (see #3038) - unable to differentiate between Combat Celebrant #1 and Combat Celebrant #2 .Will need to ask users for game logs and go from there.

drmDev pushed a commit to drmDev/mage that referenced this issue Apr 24, 2017
drmDev added a commit that referenced this issue Apr 24, 2017
test for #3195 combat celebrant.
@drmDev
Copy link
Contributor

@drmDev drmDev commented Apr 26, 2017

cc-always-watch
Was able to attack again with exerted Celebrant if Always Watching is on battlefield. Also able to reproduce by unit test. Was not able to have infinite combat phases with just one Celebrant or exert more than once per turn.

edit: see later comment - misread card. Did not duplicate being able to exert more than once per turn.

@drmDev
Copy link
Contributor

@drmDev drmDev commented Apr 26, 2017

With 2 Celebrants + Always Watching you get two additional combat phases by attacking with one Celebrant and Exerting then attacking with the other and exerting it. However unable to exert either of them more than once per turn
cc-always-watch-inf

edit: see later comment - misread card. Did not duplicate being able to exert more than once per turn.

@drmDev
Copy link
Contributor

@drmDev drmDev commented Apr 26, 2017

edit: see later comment - misread card. Did not duplicate being able to exert more than once per turn.

drmDev added a commit to drmDev/mage that referenced this issue Apr 26, 2017
drmDev added a commit that referenced this issue Apr 26, 2017
Unit test confirming issue #3195 with Combat Celebrant
@drmDev drmDev added the AKH label Apr 26, 2017
@drmDev
Copy link
Contributor

@drmDev drmDev commented Apr 26, 2017

Update: I need to RTFC and rules better. Celebrant is allowed to attack again if he is exerted. Just not allowed to be exerted again on the same turn to grant additional combat phases. Not able to duplicate the issue then, just misunderstood the interactions here.

drmDev added a commit that referenced this issue Apr 26, 2017
fixed UT for #3195. misinterpretted ruling. closing #3195
@drmDev
Copy link
Contributor

@drmDev drmDev commented Apr 26, 2017

I'm going to guess then the issue was the users misread the first line as Celebrant not being able to attack again while exerted. Will re-open if someone can produce a log demonstrating infinite turns with it exerting more than once a turn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants