Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest of Scarabs various issues #3402

Closed
drmDev opened this issue May 20, 2017 · 6 comments
Closed

Nest of Scarabs various issues #3402

drmDev opened this issue May 20, 2017 · 6 comments

Comments

@drmDev
Copy link
Contributor

@drmDev drmDev commented May 20, 2017

Added 3 more tests for Nest of Scarabs. previous tests only were on counters placed on own creatures.

Tests failing at the moment:

  1. Player with Scarabs out casts Black Sun's Zenith targetting 1 of own creature and 3 of opponents. Only getting 1 token.
  2. Both players have Scarabs out, same scenario as above. The opponent is getting 3 tokens when they should be getting 0 and the caster of Zenith is only getting 1 token.
  3. Infect damage is not triggering Scarabs.
@drmDev drmDev added the bug label May 20, 2017
drmDev added a commit that referenced this issue May 20, 2017
drmDev pushed a commit to drmDev/mage that referenced this issue May 20, 2017
drmDev added a commit that referenced this issue May 20, 2017
only fixes 2 of 3 issues with Scarabs. infect damage not triggering infect still for #3402
@drmDev
Copy link
Contributor Author

@drmDev drmDev commented May 20, 2017

With Infect, boolean weAreDoingIt = getControllerId().equals(game.getControllerId(event.getSourceId())); event.getSourceId() is returning null here. Not sure how this is working with Hapatra with infect damage that was resolved with a similar change?

Anyways... commit referenced above fixes the first 2 issues. Only the infect issue remains.

@drmDev
Copy link
Contributor Author

@drmDev drmDev commented May 20, 2017

forgot to link the tests commit: e7963de

@drmDev drmDev added the AKH label May 21, 2017
@drmDev
Copy link
Contributor Author

@drmDev drmDev commented Jun 4, 2017

There's also a report Nest of Scarabs is not triggering off Wither. will add test

@drmDev
Copy link
Contributor Author

@drmDev drmDev commented Jun 5, 2017

All tests are passing now. User on subreddit claims wither is not triggering. Will need to test manually.

drmDev added a commit that referenced this issue Jun 5, 2017
added nest of scarabs test for wither. unable to replicate #3402
@Zerrisx
Copy link

@Zerrisx Zerrisx commented Jun 27, 2020

Confirmed still bugged; puncture blast gives no scarabs:
image

@Zerrisx Zerrisx mentioned this issue Jun 27, 2020
4 of 26 tasks
@Zerrisx
Copy link

@Zerrisx Zerrisx commented Jul 15, 2020

Duplicate of #5886

@Zerrisx Zerrisx marked this as a duplicate of #5886 Jul 15, 2020
@Zerrisx Zerrisx closed this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants