Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbilityPicker - strange handling of wrong click #420

Closed
LevelX2 opened this issue Apr 25, 2014 · 5 comments
Closed

AbilityPicker - strange handling of wrong click #420

LevelX2 opened this issue Apr 25, 2014 · 5 comments
Labels

Comments

@LevelX2
Copy link
Contributor

@LevelX2 LevelX2 commented Apr 25, 2014

If the ability picker is open (e.g. if a permanent has two activated ability) and you click for some reason not at one of the possible choices in the picker but on a permanent or card instead, the ability picker stays open.
But as you click now on one of the choices the ability picker closes (as normal) but ignore your click. Can be quite frustrating as you sometimes tap now mana and click ok, without realizing the spell is not cast. So your mana is wasted.

Expected behaviour:
Best - The ability picker selects the choice with your click instead of only closing.
Second best -The ability picker closes as soon as you click at another card or permanent.

@LevelX2 LevelX2 added the bug label Apr 25, 2014
@magenoxx
Copy link
Member

@magenoxx magenoxx commented Apr 28, 2014

how to reproduce it? I mean is there any init.txt for such case?

@LevelX2
Copy link
Contributor Author

@LevelX2 LevelX2 commented Apr 28, 2014

To Reproduce:

  1. Click e.g. on a bestow enchantment creature card on your hand.
  2. The ability picker window opens, with three choices.
  3. Click now on any other card/permanent outside the ability picker window. Nothing happens, the ability picker window stays open.
  4. Now try to pick an ability from ability picker window (that's still open). You click on a choice and the window closes. But no ability is picked, Nothing happens.
@magenoxx
Copy link
Member

@magenoxx magenoxx commented Apr 30, 2014

Yes, easy reproducible. I believe it is related to losing focus on custom component.
What's the desired fix?
Easiest one - to close ability picker whenever area outside the box was clicked.
The other one - that is restoring focus - is more difficult: actually what happens - user clicks on ability but actually he doesn't and you need to emulate such ability clicking by translating area box coordinates to chosen ability option coordinates.

@LevelX2
Copy link
Contributor Author

@LevelX2 LevelX2 commented Apr 30, 2014

I guess best solution would be to let it open until user chooses an ability or the cancel selection. Because when I think about the situations I face this behaviour I guess nearly 100% of the situations I did reopen the ability picker and select the ability. But as you said, this is maybe the solution that is harder to implement.

So closing the ability picker as the user clicks outside the window is all the way better than the current behaviour of the function.

Maybe a possible solution is to make the window modal, so it can't loose the focus.

@LevelX2
Copy link
Contributor Author

@LevelX2 LevelX2 commented Jun 27, 2020

Was recently fixed.

@LevelX2 LevelX2 closed this Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants