Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Curse of" cards triggers on planeswalker (Opulence, Predation and other) #5566

Open
jeffwadsworth opened this issue Jan 31, 2019 · 8 comments

Comments

@jeffwadsworth jeffwadsworth added the bug label Jan 31, 2019
@jeffwadsworth jeffwadsworth self-assigned this Jan 31, 2019
jeffwadsworth added a commit that referenced this issue Feb 6, 2019
@jeffwadsworth jeffwadsworth reopened this Feb 6, 2019
@jeffwadsworth jeffwadsworth removed their assignment Feb 6, 2019
@jeffwadsworth

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

The trigger on this card will happen if either a player or a planeswalker is attacked. This is incorrect.

@JayDi85

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

You can add ignorePlaneswalkerAttack param to EnchantedPlayerAttackedTriggeredAbility (default is false). Same param for getPlayerDefenders (default false). Calls it from EnchantedPlayerAttackedTriggeredAbility... And change getPlayerDefenders to use new param.

@JayDi85

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Curse of Shallow Graves and other cards (search by getPlayerDefenders(game)) have same condition/code and needs to fixes too (same calls with extra param -- see above).

@jeffwadsworth

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

@JayDi85 Yes, I tried things like that but the code for combat is so convoluted, I dove into trying to straighten that out. A nightmare. It just made me move on. Perhaps you can take a fresh take at it.

@JayDi85 JayDi85 self-assigned this Feb 9, 2019
JayDi85 added a commit that referenced this issue Feb 9, 2019
@JayDi85

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

Fixed via e285b27

@JayDi85 JayDi85 closed this Feb 9, 2019
@JayDi85

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Need to checks other "curse of" cards and replace checkTrigger code to use standard getPlayerDefenders call like other working curse cards (see e285b27).

From forum:

Curse of Predation
Enchant player
Whenever a creature attacks enchanted player, put a +1/+1 counter on it.

I had a Nissa, Voice of Zendikar under my control and my opponent had a Curse of Predation targetting me. When they attacked Nissa with their Bloodbraid Elf, the Curse of Predation triggered on it. I don't think this is correct, and there is an oracle ruling explaining this:
"The ability won’t trigger when a creature attacks a planeswalker controlled by the enchanted player."

@JayDi85 JayDi85 reopened this Feb 11, 2019
@JayDi85 JayDi85 changed the title Curse of Opulence bug "Curse of" cards triggers on planeswalker (Opulence, Predation and other) Feb 11, 2019
@jeffwadsworth

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

@JayDi85 Are you doing this or does it need to be done?

@JayDi85

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Yep, I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.