Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAR - War of the Spark Set Card Implementation Tracking #5662

Closed
260 tasks done
theelk801 opened this issue Mar 28, 2019 · 14 comments
Closed
260 tasks done

WAR - War of the Spark Set Card Implementation Tracking #5662

theelk801 opened this issue Mar 28, 2019 · 14 comments

Comments

@theelk801
Copy link
Task lists! Give feedback
Contributor

@theelk801 theelk801 commented Mar 28, 2019

Mark cards you're working on in the second post of this issue.
If you can't check things off, leave a comment instead.
Once the card is committed, check off the card here to show that it's finished.
Don't worry about adding new spoilers to this list, it's generated by a script.

All Sets

Unimplemented Cards

Implemented Cards
@theelk801
Copy link
Contributor Author

@theelk801 theelk801 commented Mar 28, 2019

@JayDi85 JayDi85 pinned this issue Mar 31, 2019
@theelk801
Copy link
Contributor Author

@theelk801 theelk801 commented Apr 1, 2019

Additional tasks:

  • Update proliferate to increase all counters on a given permanent rather than just one
@JayDi85
Copy link
Member

@JayDi85 JayDi85 commented Apr 8, 2019

RELEASE reports (de-server on 2019-04-24 16:47:28):

  • Dovin passive doesn't work (chat)
  • Oath of kaya passive doesn't work (chat)
  • Ugin + Literally adds the card to your hand (chat)
  • Ugin - ugin, the inefable The first habilitiel does not work correctly. He hands me the card without the token leaving the battlefield. sorry. i don´t speak to much english. (darkaniel44, 2019-04-24 02:57:02)
  • Ugin is still bugged on standard - card should be drawn after token is removed (FarmerJoe, 2019-04-24 04:03:18)
  • Ugin the Ineffable +1 is broken - His ability should only draw the card when the token leaves play. It appears to draw the card immediately (Ezaccly, 2019-04-24 05:54:24)
  • ugin bug - Ugin, the Ineffable +1 gives you the token and the card to your hand immediately instead of not giving you the card until the token LTB (ChiefDrana, 2019-04-24 06:57:05)
  • Ugin, the Ineffable - You just draw the card with Ugin +. Holy shit this is silly. What is that *** beta server even good for? (Tyneic, 2019-04-24 12:44:58)
  • ugin bug - The new Ugin from WAR draws the cards that should be exiled with his +2 ability (salkin1997, 2019-04-24 15:34:03)
  • new ugin +1 bugged - new ugin planeswalker in WAR set has a bugged +1 ability, it draws the card it reveals immediately (Tooxie, 2019-04-24 16:37:46)
  • Ugin The Ineffable - The +1 Ability lets you draw a card right away as you use it instead of when the 2/2 token dies (edi, 2019-04-24 16:47:28)
  • Dovin, Hand of Control - The new Dovin didn't increase the cost of my opponent's Ancient Stirrings (Bob49, 2019-04-24 00:00:32)
  • Dovin, Hand of Control - The passive ability of "Dovin, Hand of Control" currently doesn't do anything (Bob49, 2019-04-24 00:09:16)
  • Dovin, Hand of Control - Passive effect doesn't work on Genesis Wave. (Tyneic, 2019-04-24 15:31:20)
  • Chandra's Triumph bugged - Hi!, Chandra's Triumph always deals 5 damage, even if you dont have a chandra planeswalker (anelintruder, 2019-04-24 00:29:29)
  • Gideon Blackblade bug - I attacked a player who had a Sarkhan, the masterless with my Gideon Blackblade and my Gideon kept taking damage from Sarkhan's static, even though Gideon's static ability prevents all damage done to him on my turn. (alana, 2019-04-24 04:22:37)
  • Feather Bug - feathers trigger doesnt work with split cards as the card resolves it goes to the graveyard (Mack1in, 2019-04-24 04:57:38)
  • Vaevictus the dire - the sacrifice trigger didnt happen after the new war of spark patch was updated (Erevain, 2019-04-24 05:37:11)
  • neoform - neoform doesn't let the creature enter with the aditional +1/+1 counter (davidalberts32, 2019-04-24 11:03:36)
  • Tidehollow Sculler doesn't work - If you sacrifice while Tidehollow Sculler's ability is on the stack, it just doesn't work. I couldn't see my opponents hand and nothing got exiled. I used Phyrexian Tower to sacrifice it. HOW THE *** DO YOU PATCH IN NEW BUGS? THIS USED TO WORK PROPERLY! (Tyneic, 2019-04-24 12:26:27)
  • Pauper's Cage - Also not working at all. I genuinely don't get how you manage to add more bugs each expansion, especially since all those cards used to work just fine. (Tyneic, 2019-04-24 12:53:37)
  • Ravnica Allegiance Image Bug - The Simic Forest and Island have their images swapped (skuggi, 2019-04-24 14:52:24) JayDi85: it's old set wrong images -- just re-download old sets with redownload checkbox.
  • Oath of Kaya - The second part doesn't work. Holy shit you guys *** up big time. (Tyneic, 2019-04-24 16:22:59)
  • Neoform is bugged - Neoform does not cause creature to enter with counter (ImNotSubtle, 2019-04-24 16:46:16)

BETA reports:

  • Interplanar Beacon works incorrectly. It allows you to add two mana in ANY COMBINATION of colours to be added to your mana pool. Instead of two mana of different colours (19 Mar 2018, Hoac, forum).
  • Ignite the Beacon does not restrict the search to planeswalkers, you can search for any 2 cards you want at instant speed (19 Mar 2018, Hoac, forum).
  • Massacre Girl's second ability didn't trigger when it killed my 1/1 zombie army, screenshot (Zerris, discord);
  • Angrath, Captain of Chaos' -2 is currently set to a -X (screenshot) (Zerris, discord);
  • Ajani, the Greathearted has no loyalty set, so it just dies when you cast it, screenshot (Zerris, discord);
  • Jace, Wielder of Mysteries says "That target" instead of "target player", screenshot, And if you "cancel" the ability, it targets nobody, no cards go to the graveyard, and you still draw 1 screenshot (Zerris, discord);
  • Widespread Brutality triggers in the wrong order - it deals damage, then amasses, screenshot. Notice that it made my 1/1 into a 3/3... but only dealt 1 damage to each other creature (Zerris, discord);
  • Ravnica at War says "Exile all permanent" rather than "Exile all multicolored permanents". And oh boy, it sure does, screenshot (Zerris, discord);
  • Samut, Tyrant Smasher is missing a space in her hover text before "Scry 1", screenshot (Zerris, discord);
  • Nahiri's text is completely wrong for her -X screenshot (Zerris, discord);
  • Blindblast is also missing a space in the hover text screenshot (Zerris, discord);
  • I cast Gideon's Triumph on my opponent during blocks; they sacrificed their creature in response to kill a walker with Heartfire. Then when Gideon's Triump finally resolved... they sacrificed a Steam Vents to it!? That's definitely not an attacking or blocking creature. screenshot (Zerris, discord);
  • Tibalt's Rager is missing the damage on death trigger. screenshot (Zerris, discord);
  • Neheb, Dreadhorde General does the right thing, but has the wrong ability text - it says "to a player", despite (correctly!) also triggering on planeswalker damage. screenshot (Zerris, discord);
  • Proliferate has no chat-message about what the player did, which makes it much harder to track - it would be nice to get a " proliferated on <names of permanents, players> (Zerris, discord);
  • My opponent's Grim Initiate died, but it didn't amass an army. it looks like doing Angrath for X=0 might have broken Amass in general at least for my opponent. screenshot 1, screenshot 2 (Zerris, discord);
  • When Dovin's Veto can't be countered, it tells you so twice in the chat log. I suspect one of those is the "FYI this can't be countered" and the other is the "So the occurring game action was that it didn't get countered", but afaik, there's no way that state could change between those two messages, so the first will always be redundant. screenshot (Zerris, discord);
  • Lazotep Plating is slightly off in the hover text - it should be "You and permanents", screenshot (Zerris, discord);
  • Tezzeret, Master of the Bridge's Ultimate doesn't do anything. Nothing gets exiled, nothing is available to cast... it just says this text in chat and removes 8 loyalty. screenshot (Zerris, discord);
  • Liliana, Dreadhorde General's Ultimate makes you select one of each type of permanent you control, which is wrong, screenshot, But then also doesn't make you sac them, screenshot It only makes opponents sacrifice things, so you shouldn't ever be choosing anything at all (Zerris, discord);
  • Nahiri, Storm of Stone failed to reduce the equip cost on Dowsing Dagger, screenshot (Zerris, discord);
  • Privileged Position says "Other permanent" rather than "Other permanents", screenshot (Zerris, discord);
  • When my opponent has a Teyo, the Shieldmage in play, and I have Kaya, Bane of the Dead, I am still unable to target them despite Kaya's passive overriding Teyo's. screenshot. However, I am able to target other permanents through privileged position
    so the bug is likely with Teyo giving a broken version of hexproof (or Kaya missing the "Opponents" part of her passive) (Zerris, discord);
  • Niv-Mizzet Reborn's etb does not function properly. Upon having him enter the battlefield, I was unable to choose Tezzeret, Master of the Bridge, as a target, although I skipped until the option to choose a blue and black card (out of the top ten cards). No card was highlighted, and none could be picked up (forum)

AI:

  • Also, while not a card bug, the AI likes to attack whenever it has creatures with toughness greater than any individual blocker - but makes no math at all for multi-blocks
    i.e. it just attacked with Trostani (and suicided it) on this board: screenshot, Where a 1/4 is a horrific attack into a 3/3 and a 1/2 (Zerris, discord);
  • The AI also seems to have no understanding of how First Strike works - it's blocking my 2/3 first striker with a single 3/2 each combat, and similar plays. (Said first strike was granted by Nahiri rather than being inherent, if relevant) (Zerris, discord);

Other cards TODO and checks:

  • Privileged Position says "Other permanent" rather than "Other permanents"... There are boatloads of typos like that on hints Iunno... I suspect it's actually a single typo-form, which is to say that "other permanent" in general seems to come up a lot so you could probably figure out the common theme behind that one at least and grab a lot of cards with it

There was another one like that that I see a lot...I can't remember what it is
I think it might be spells with multiple targets breaking up into 'target x does x', 'target x (or y) does x (or y)', etc., but I think the type word is always missing
Something like that
I think it's specifically for spells where you can legally target the same permanent multiple times
(Or maybe player, if there are any cards like that)
I'll see if I can't find an example

@antoni-g
Copy link
Contributor

@antoni-g antoni-g commented Apr 13, 2019

Hi all,

I'm going to jump in and do:
Centaur Nurturer
Contentious Plan

@CCTV-1
Copy link
Contributor

@CCTV-1 CCTV-1 commented Apr 17, 2019

Awakening of Vitu-Ghazi convert land, then 10 +1/+1 counter in land,xmage display 5/5(build:19-04-13 03:28 )
S5W7RQCXWZJ0HT ~@UA@MXU

@ninf-fct
Copy link

@ninf-fct ninf-fct commented Apr 17, 2019

Feather seems to have a bug where it's ability is triggered even by spells controlled by the opponent if they target your creatures. This only seems to happen in a Feather mirror match.

@theelk801
Copy link
Contributor Author

@theelk801 theelk801 commented Apr 17, 2019

Thanks, I'll look into it

@CCTV-1
Copy link
Contributor

@CCTV-1 CCTV-1 commented Apr 19, 2019

in my turn Gideon Blackblade not is creature
can't cast Gideon's Triumph,this is exception message:

Game exception occurred: java.lang.NullPointerException
Server version: 1.4.34V1.5 (build: 2019-04-18 12:55)
mage.cards.g.GideonsTriumphCondition.apply(GideonsTriumph.java:91)
mage.cards.g.GideonsTriumphCondition.apply(GideonsTriumph.java:85)
mage.filter.predicate.Predicates$AndPredicate.lambda$apply$0(Predicates.java:145)
java.util.stream.MatchOps$1MatchSink.accept(Unknown Source)
java.util.ArrayList$ArrayListSpliterator.tryAdvance(Unknown Source)
java.util.stream.ReferencePipeline.forEachWithCancel(Unknown Source)
java.util.stream.AbstractPipeline.copyIntoWithCancel(Unknown Source)
java.util.stream.AbstractPipeline.copyInto(Unknown Source)
java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
java.util.stream.MatchOps$MatchOp.evaluateSequential(Unknown Source)
java.util.stream.MatchOps$MatchOp.evaluateSequential(Unknown Source)
java.util.stream.AbstractPipeline.evaluate(Unknown Source)
java.util.stream.ReferencePipeline.allMatch(Unknown Source)
mage.filter.predicate.Predicates$AndPredicate.apply(Predicates.java:145)
mage.filter.FilterImpl.match(FilterImpl.java:38)
mage.game.permanent.Battlefield.lambda$countAll$0(Battlefield.java:63)
java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
java.util.Iterator.forEachRemaining(Unknown Source)
java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source)
java.util.stream.AbstractPipeline.copyInto(Unknown Source)
java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
java.util.stream.ReduceOps$ReduceOp.evaluateSequential(Unknown Source)
java.util.stream.AbstractPipeline.evaluate(Unknown Source)
java.util.stream.LongPipeline.reduce(Unknown Source)
java.util.stream.LongPipeline.sum(Unknown Source)
java.util.stream.ReferencePipeline.count(Unknown Source)
mage.game.permanent.Battlefield.countAll(Battlefield.java:65)
mage.abilities.effects.common.SacrificeEffect.apply(SacrificeEffect.java:56)
mage.cards.g.GideonsTriumphEffect.apply(GideonsTriumph.java:81)
mage.abilities.AbilityImpl.resolveMode(AbilityImpl.java:176)
mage.abilities.AbilityImpl.resolve(AbilityImpl.java:166)
mage.game.stack.Spell.resolve(Spell.java:220)
mage.game.GameImpl.resolve(GameImpl.java:1319)
mage.game.GameImpl.playPriority(GameImpl.java:1269)
mage.game.turn.Step.priority(Step.java:61)
mage.game.turn.CombatDamageStep.priority(CombatDamageStep.java:31)
mage.game.turn.Phase.playStep(Phase.java:184)
mage.game.turn.Phase.play(Phase.java:89)
mage.game.turn.Turn.play(Turn.java:127)
mage.game.GameImpl.playTurn(GameImpl.java:850)
mage.game.GameImpl.play(GameImpl.java:759)
mage.game.GameImpl.start(GameImpl.java:723)
mage.server.game.GameWorker.call(GameWorker.java:34)
java.util.concurrent.FutureTask.run(Unknown Source)
java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

client version:1.4.33.dev_2019-04-18_12-59

@theelk801
Copy link
Contributor Author

@theelk801 theelk801 commented Apr 19, 2019

I'm pushing fixes for both of those, thanks

@antoni-g
Copy link
Contributor

@antoni-g antoni-g commented Apr 19, 2019

chiming in - grabbing Ugin's Conjurant and Finale of Devastation

@messuped
Copy link

@messuped messuped commented Apr 21, 2019

Thanks, I'll look into it

I think I may have an idea on the Feather bug (since it just happened).

I was in an EDH game with 4 other people and I had cast a cantrip with Feather out (so naturally, the trigger occurred). Then the blue player answered with Reality Shift on my other creature (note, not Feather). At the end step, his cantrip was returned to his hand, and not mine.

Maybe it is a fault on the way Feather chooses which cantrip to return to hand, picking the last card on the stack? Not sure, haven't studied Feather's code extensively.

@messuped
Copy link

@messuped messuped commented Apr 21, 2019

Thanks, I'll look into it

I think I may have an idea on the Feather bug (since it just happened).

I was in an EDH game with 4 other people and I had cast a cantrip with Feather out (so naturally, the trigger occurred). Then the blue player answered with Reality Shift on my other creature (note, not Feather). At the end step, his cantrip was returned to his hand, and not mine.

Maybe it is a fault on the way Feather chooses which cantrip to return to hand, picking the last card on the stack? Not sure, haven't studied Feather's code extensively.

image

This also happened on a turn Feather was in exile at the begining of the turn (she wasn't present for the casting of the five spells)

@JayDi85
Copy link
Member

@JayDi85 JayDi85 commented Apr 24, 2019

Bug reports from de-server about new cards added to post above:
#5662 (comment)

@JayDi85 JayDi85 unpinned this issue May 2, 2019
@JayDi85 JayDi85 closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants