Shortcut/Macro System

[ruler501]

Added a system for recording shorcuts and executing them a set number of times. Likely still needs some UX work and automated tests. Solves the issue raised in #2147 with something very similar to the proposed solution.

Had a lot of help from @bhomer7 designing and testing it. We tested Kitchen Finks/Viscera Seer/Vizier of Remedies, Whispers of the Muse/Paradox Engine, Vizier of Remedies/Devoted Druid, Haze of Rage/Paradox Engine and all were able to work, though it can take a while to execute large numbers of iterations.

[drmDev]

Why are these tests being removed? They fail currently due to bugs in code and should be preserved until we resolve the issues. If you believe the tests are inaccurate, i.e. an issue with the testing framework itself, then @ignore annotation is more appropriate than commenting out tests (otherwise we cannot find them again)

[drmDev]

Why are these tests being removed? They fail currently due to bugs in code and should be preserved until we resolve the issues. If you believe the tests are inaccurate, i.e. an issue with the testing framework itself, then @ignore annotation is more appropriate than commenting out tests (otherwise we cannot find them again)

[drmDev]

Uncomment the failing tests. Use @ignore annotation if issue with Testing Framework causing the failures, or keep them as is if they are failing due to bug in code.

[Simown]

Not a fan of these conditions and execution on the same line. Condition at least should go on a new line indented - it's hard to see code flow especially with the return inline here.

[ingmargoudt]

why a new String() here?

[ruler501]

There are a couple problems remaining in this.
Card selection in pop ups doesn't work(for instance scrying to bottom with viscera seer/kitchen finks) but will work if you just let it stay on top which might be reasonable.
If someone interrupts it doesn't stop. Currently coming up with a design to prompt user if they want to continue if something unexpected happens and how to detect that.

These are probably okay as long as players are aware that if they select a card while recording and that card isn't a choice later on that the macro won't work and that the players ask if anyone will want to interrupt and if so how many iterations are okay to run.

[spjspj]

Out of curiosity, does this work with casting something from hand? Like say having paradox engine in play and shrieking drake? (Infinite mana, infinite storm count)

[ruler501]

Yes it was testing with Haze of Rage, Paradox Engine, and mana rocks to cast it with buyback. So cast, storm trigger resolves, copies resolve, paradox engine resolves, original resolves and returns to hand, repeat. As a warning it can get quite slow after 50 or so iterations just because of how the mage engine works, but storm 50 is usually enough.
It will not support picking different targets each time(such as if you had shrieking drake, panharmonicon to bounce all your creatures). Some less obvious cases where this comes up is when scrying. If you want to scry to bottom it won't work since you have to select a different card each time. If you hit done though it will work(tested with viscera seer/kitchen finks)

[LevelX2]

Thanks for your contribution.

[PrometeusGod]

Does it do the Eggs Loop Combo?

[bhomer7]

Yes, it will do the Eggs Loop Combo. Tested using Pyrite Spellbomb, Faith's Reward, and Conjurer's Bauble, making mana with both Krark Clan Ironworks with Chromatic Stars or with Lotus Blooms.
As long as the combo can be done with an unchanging set of pieces of cardboard, with the same targets at each step, the combo can be recorded and played back.

[PrometeusGod]

About the Eggs Combo.
What if it draws you a card or mills a card every loop?

[bhomer7]

The final kill process of the Eggs Loop Combo can be automated. The setup, where new cards have to be added from your library to your hand to the battlefield to the graveyard and back cannot be automated. The set of cards to be included in the loop must be completely present and selectable during the first iteration.