Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Love for Assigned Sources] Notify Quantity #2132

Closed
ishakhsuvarov opened this issue Apr 3, 2019 · 1 comment
Closed

[UI Love for Assigned Sources] Notify Quantity #2132

ishakhsuvarov opened this issue Apr 3, 2019 · 1 comment
Assignees
@fratob85
Milestone
MSI Part III

Comments

@ishakhsuvarov
Copy link
Contributor

Description

This ticket is created in effort to split #2061 into smaller and more manageable items.

Assigned Sources panel, located on the Product Edit page has a lot of tightly packed controls, some of which may be (re)moved to maintain cleaner look and better experience.

To Do

  1. Eliminate column Notify Quantity Use Default on the Assigned Sources panel.
  2. Move checkbox which was in that column to Notify Qty column below the number input with Use Default label.
  3. Make sure that fields are still enabled/disabled correctly and values saved as expected.
  4. Adjust any functional tests which may or may not start failing after this change.
@ishakhsuvarov ishakhsuvarov added this to the MSI Part III milestone Apr 3, 2019
@fratob85 fratob85 self-assigned this Apr 5, 2019
fratob85 added a commit that referenced this issue Apr 6, 2019
@fratob85
fix: elimate column Notify Quantity Use Default and move checkbox to …
9a7973f 
…Notify Qty column

Issue: #2132

These changes have been made in the Assigned Source panel:
  - Eliminated column "Notify Quantity Use Default"
  - Moved checkbox which was in column "Notify Quantity Use Default"
    to "Notifiy Qty" column below the number input
   - Added "Use Default" description to the checkbox
@fratob85 fratob85 mentioned this issue Apr 6, 2019
Merged
4 tasks
ishakhsuvarov added a commit that referenced this issue Apr 8, 2019
@ishakhsuvarov
Merge pull request #2149 from magento-engcom/msi-2132
39c7d0e 
[UI Love for Assigned Sources] Notify Quantity #2132
@ishakhsuvarov
Copy link
Contributor Author

Closing, as issue is fixed in #2149 by @fratob85

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fratob85 fratob85

Labels
None yet
Projects
None yet
Milestone
MSI Part III
Development

No branches or pull requests
3 participants
@maghamed @ishakhsuvarov @fratob85