New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance based source selection algorithm #1866

Merged
merged 75 commits into from Jan 21, 2019

Conversation

@phoenix128
Copy link
Collaborator

phoenix128 commented Nov 2, 2018

Distance based source selection algorithm

#1991

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@phoenix128 phoenix128 force-pushed the distance-based-source-selection-algorythm branch 2 times, most recently from 7400b71 to 58dd9cb Nov 2, 2018

@phoenix128 phoenix128 changed the title WIP: Distance based source selection algorithm Distance based source selection algorithm Nov 2, 2018

@maghamed maghamed added the MageConf18 label Nov 12, 2018

@phoenix128 phoenix128 force-pushed the distance-based-source-selection-algorythm branch from 12a8b72 to e507596 Nov 23, 2018

@lorikrell

This comment has been minimized.

Copy link

lorikrell commented Nov 30, 2018

@phoenix128
Error Question: I didn't enter a Google API key and tried using the Distance SSA for a shipment. I received this error:

A technical problem with the server created an error. Try again to continue what you were doing. If the problem persists, try again later.

Is this an error message for any issue that occurs in MSI?
Specific to not detecting the API key?
Specific to the Distance SSA?

Recommendation, but may need to be edited further depending on scenario:

A technical issue occurred. Verify your store configuration settings, and try applying the Source Selection Algorithm again.

(maybe also with a link to the Stores > Configuration > Inventory page for store configuration?)

Also would the troubleshooting be:

  • Verify your Google API key and settings in Google
  • Could a server/other issue be happening? If so, what might those be, anything they can do or just wait and try again?

Also would you like a documentation link for error messages/troubleshooting? I plan on covering troubleshooting in the docs.

@lorikrell
Copy link

lorikrell left a comment

Entered a review on the Store > Configuration text.

Update app/code/Magento/InventorySourceSelectionAdminUi/etc/adminhtml…
…/system.xml

Co-Authored-By: phoenix128 <riccardo.tempesta@gmail.com>
@magento-cicd2

This comment has been minimized.

Copy link

magento-cicd2 commented Dec 2, 2018

CLA assistant check
All committers have signed the CLA.

IvanPletnyov added a commit that referenced this pull request Jan 18, 2019

IvanPletnyov added a commit that referenced this pull request Jan 18, 2019

phoenix128 and others added some commits Jan 18, 2019

Merge pull request #1986 from magento-engcom/MSI-1866
MSI-1866: Changes to Source Selection Service Contracts

@maghamed maghamed merged commit ab5d971 into 2.3-develop Jan 21, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Jan 21, 2019

Hi @phoenix128, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment