Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Eliminate usage of Zend_Feed from Magento 2 Open Source #70

Closed
vkublytskyi opened this issue Feb 17, 2018 · 2 comments
Closed

Eliminate usage of Zend_Feed from Magento 2 Open Source #70

vkublytskyi opened this issue Feb 17, 2018 · 2 comments
Assignees

Comments

@vkublytskyi
Copy link

References count: 3
Used in EE/B2B: no

Acceptance Criteria:

  1. Usage of Zend_Feed removed from Magento 2 Open Source
    • all references to Zend_Feed are removed from Magento 2 Open Source
    • added static a test that verifies that Zend_Feed is not used
    • Travis builds are green on PHP 7.1 environment
    • all backward incompatible changes are documented (if any)
    • if possible ZF1 component replaced by embedded PHP functionality or PSR interface otherwise migrated to ZF2
    • if ZF1 component replaced by ZF2 component:
      • there is an explanation why it is required to use external dependency
      • if usage of old ZF1 component was exposed in M2 interface/class signatures it is removed for new code
      • there is a list of PHP 7.2 compatibility issues of new ZF2 component
        OR
  2. There is an explanation why it is impossible to delete this dependency now:
    • described scope of work that is necessary to totally remove usage of Zend_Feed
    • described what backward incompatible changes will be caused by dependency removal
    • listed what other ZF1 components are required for Zend_Feed to support M2
      (if only limited functionality of Zend_Feed is used by M2
      then not all dependencies may be required and some part of Zend_Feed
      still may be removed if has incompatibility with PHP 7.2)
    • listed PHP 7.2 compatibility issues for Zend_Feed

May be fixed in magento/magento2#9347

@buskamuza
Copy link
Contributor

buskamuza commented Mar 13, 2018

  • Review passed
  • Internal ticket ENGCOM-891
  • QA:
    • RSS feed

@RyanZolper
Copy link

QA approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants