Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust technical guidelines event observer example #4328

Conversation

@serhiyzhovnir
Copy link
Contributor

commented Apr 24, 2019

Purpose of this PR

This PR adjusts the observer example which is shown on the technical guidelines page.
The observer interface implementation was missed in the observer example.

Affected URLs

whatsnew
Added the observer interface implementation to the observer example in the technical guidelines

@magento-cicd2

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

CLA assistant check
All committers have signed the CLA.

@devops-devdocs

This comment has been minimized.

Copy link

commented Apr 24, 2019

An admin must run tests on this PR before it can be merged.

@ronak2ram ronak2ram self-requested a review Apr 24, 2019

@ronak2ram ronak2ram self-assigned this Apr 24, 2019

@jeff-matthews jeff-matthews requested a review from buskamuza Apr 24, 2019

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Changes to coding standards, technical guidelines, and/or technical vision must be approved by the Magento architects. Do not merge until all architect reviewers approve.

serhiyzhovnir added some commits May 9, 2019

Merge branch 'master' of github.com:magento/devdocs into adjust-techn…
…ical-guidelines-observer-example

# Conflicts:
#	guides/v2.2/coding-standards/technical-guidelines.md

@jeff-matthews jeff-matthews added this to Backlog in Processing PRs via automation May 10, 2019

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

running tests

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

There's an issue with the build server, which is why tests failed. We're troubleshooting the error and will test this PR later.

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

running tests

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

running tests

@jeff-matthews jeff-matthews merged commit 9dd9d90 into magento:master May 10, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented May 10, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Processing PRs automation moved this from Backlog to Done May 10, 2019

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Thanks @serhiyzhovnir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.