Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4762 Provide information about colorPicker Ui Component #4885

Merged
merged 7 commits into from Jul 9, 2019

Conversation

@devops-devdocs

This comment has been minimized.

Copy link

commented Jul 3, 2019

An admin must run tests on this PR before it can be merged.

@osrecio osrecio self-assigned this Jul 4, 2019

@jeff-matthews jeff-matthews added this to Backlog in Processing PRs via automation Jul 8, 2019

@erikmarr erikmarr self-requested a review Jul 8, 2019

Processing PRs automation moved this from Backlog to Needs writer approval Jul 8, 2019

@erikmarr

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

@diazwatson please update the "Links to Magento source code" section in the PR description so you're linking to the master branch instead of dev branch.

@diazwatson

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

Hi @erikmarr thanks for reviewing this PR.
Requested changes are done.

diazwatson added some commits Jul 8, 2019

@osrecio

osrecio approved these changes Jul 9, 2019

Processing PRs automation moved this from Needs writer approval to Needs Jenkins testing Jul 9, 2019

@erikmarr

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

running tests

@erikmarr

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

running tests

@erikmarr erikmarr merged commit 7687322 into magento:master Jul 9, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Jul 9, 2019

Hi @diazwatson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Processing PRs automation moved this from Needs Jenkins testing to Done Jul 9, 2019

@erikmarr

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Thanks @diazwatson!

@diazwatson

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Thank you guys for the support @erikmarr @osrecio 👍

@diazwatson diazwatson deleted the diazwatson:4762_ColorPickerComponent branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.