Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed legacy Cloud infrastructure info #5125

Merged
merged 8 commits into from Aug 22, 2019

Conversation

@meker12
Copy link
Contributor

commented Aug 6, 2019

Purpose of this pull request

Update Cloud documentation to remove legacy infrastructure references and instructions:

  • Remove references to projects provisioned before October 23, 2017
  • Remove "submit support ticket" references for environment config changes on Pro Staging and Production environments
  • Remove Pro Architecture (legacy) topic
  • Remove instructions for migrating projects from legacy infrastructure in Add Staging and Production to Pro Project UI topic
  • Remove references to deleted topics, and add redirects as needed
  • Clean up markdown syntax

Validation

  • Build preview
  • Verify that instructions and references to legacy Cloud projects and project configurations have been removed
  • Editorial review

Affected DevDocs pages

whatsnew
Updated Magento Commerce Cloud Guide to remove obsolete instructions for configuring legacy environments and migrating legacy Cloud environments to use the Project Web UI. Legacy environments are those provisioned prior to October 23, 2017.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Aug 6, 2019

@meker12 meker12 self-assigned this Aug 6, 2019

@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 6, 2019

@meker12 meker12 added the 2.x label Aug 6, 2019

@meker12 meker12 requested a review from hguthrie Aug 6, 2019

@meker12 meker12 marked this pull request as ready for review Aug 6, 2019

@hguthrie
Copy link
Contributor

left a comment

This cleans up a lot, and we need this. But this is a lot to review because I think that you creeped in scope many times. I understand the temptation; these improvements help greatly, but still a lot to review! In the spirit of your cleansing, I added a couple of quick suggestions to clear some command steps.

_includes/cloud/hooks.md Outdated Show resolved Hide resolved
guides/v2.2/cloud/configure/setup-cron-jobs.md Outdated Show resolved Hide resolved
guides/v2.2/cloud/configure/setup-cron-jobs.md Outdated Show resolved Hide resolved
guides/v2.2/cloud/live/stage-prod-migrate-prereq.md Outdated Show resolved Hide resolved
guides/v2.2/cloud/project/project-upgrade.md Outdated Show resolved Hide resolved
* For Starter, we recommend you create a `staging` branch from Master, then branch from `staging` for development.
* For Pro, you want to branch from Development (Integration `master`).
- For Starter, we recommend you create a `staging` branch from Master, then branch from `staging` for development.
- For Pro, you want to branch from the development branch (Integration `master`).

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 6, 2019

Contributor
Suggested change
- For Pro, you want to branch from the development branch (Integration `master`).
- For Pro, create a development branch from the Integration environment.
- `magento-cloud user:add` adds a user to the project
- `magento-cloud user:delete` deletes a user
- `magento-cloud user:list [users]` lists project users
- `magento-cloud user:role` views or change a user's role

For example, the following command adds the project administrator (`admin`) role to `alice@example.com` and gives her `contributor` privileges to the `development` environment:

The following prompts are displayed:

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 6, 2019

Contributor
Suggested change
The following prompts are displayed:

* **Staging and Production environments in the UI for Pro projects**. Starting October 23, 2017, all projects created using the free 30-day trial or provisioned for new accounts includes Staging and Production environments in the Project Web Interface. Existing accounts created before October 23, 2017 can enter a ticket to be updated. For more information, see [Add Staging and Production to Pro projects UI]({{ site.baseurl }}/guides/v2.2/cloud/trouble/pro-env-management.html).
* **Staging and Production environments in the UI for Pro projects**. Starting October 23, 2017, all projects created using the free 30-day trial or provisioned for new accounts includes Staging and Production environments in the Project Web Interface. See

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 6, 2019

Contributor

See is left open-ended...

guides/v2.3/cloud/project/projects.md Outdated Show resolved Hide resolved

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Request Progress Aug 6, 2019

Apply suggestions from code review
Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>

@meker12 meker12 requested a review from skotasthane Aug 6, 2019

@meker12 meker12 requested review from hguthrie and jeff-matthews Aug 22, 2019

url: /cloud/architecture/pro-architecture-legacy.html

- label: Add Staging and Production to Pro projects UI
url: /cloud/trouble/pro-env-management.html

This comment has been minimized.

Copy link
@jeff-matthews

jeff-matthews Aug 22, 2019

Contributor

There are still links to this topic in the whatsnew topic. It will likely fail link checking. Should this redirect somewhere?

This comment has been minimized.

Copy link
@meker12

meker12 Aug 22, 2019

Author Contributor

👍 Added a redirect to the Pro develop and deploy workflow topic.


### Migrate your `.magento.app.yaml` file {#pro-yaml}

**Important:** If you have **not modified** the default deployment hooks or configurations, skip this step and continue with [Get your Pro access URLs](#pro-urls). Only migrate the file if you modified the deployment hooks or added configuration updates.
{:.bs-callout-important}

This comment has been minimized.

Copy link
@jeff-matthews

jeff-matthews Aug 22, 2019

Contributor

The important class doesn't exist. You can use info, warning, or tip.

Made the requested change, but the reviewer is on vacation. Can make further updates to content on a separate PR as needed.

@meker12

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

running tests

@meker12 meker12 merged commit 2627f1e into master Aug 22, 2019

1 check passed

Jenkins Tests passed
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 22, 2019

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Changes Requested to Done in Pull Request Progress Aug 22, 2019

@meker12 meker12 deleted the mae-MAGECLOUD-3462-remove-legacy-info branch Aug 22, 2019

diazwatson added a commit to diazwatson/devdocs that referenced this pull request Aug 24, 2019
Merge remote-tracking branch 'upstream/master' into 5115_viewModels
* upstream/master: (42 commits)
  Update Magento 2.3.0 Open Source release notes (magento#5267)
  changed "change" to "remove" per Anthony chico
  Small changes (magento#5264)
  changed column name to ital instead of code
  magento/devdocs#: Fix release notice info about STATIC_CONTENT_THREADS and change info on the appropriate pages (magento#5263)
  Updated instructions for reviewing cron configuration (magento#5239)
  Add GSC meta tag (magento#5258)
  updated code language
  Add GTM tag in order to verify site in GSC (magento#5254)
  Added note for 404 errors
  MAGEDOC-4061: Added Q3 Commerce releases (magento#5236)
  Change wording
  Removed legacy Cloud infrastructure info (magento#5125)
  Removed the unused files
  Fix style violations
  Updated What's New for documentation updates since Aug 9, 2019 (magento#5212)
  Update debug.md (magento#5134)
  Link to new marketing PDF from release info page (magento#5223)
  Debug logging options should match sentence context (magento#5219)
  Remove spaces inside link text
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.