Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting the Change Increment ID KB to devdocs #5129

Merged
merged 15 commits into from Aug 15, 2019

Conversation

@dobooth
Copy link
Contributor

commented Aug 6, 2019

Purpose of this pull request

This pull request (PR) converts a KB article into a devdoc.

Affected DevDocs pages

whatsnew
Added the Change increment ID for a database entity on particular store topic to the Configuration Guide.

@dobooth dobooth self-assigned this Aug 6, 2019

@m2-community-project m2-community-project bot added this to Review in Progress in Pull Request Progress Aug 6, 2019

@dobooth dobooth changed the title Db kb conversion Converting the Change Increment Id KB to devdocs Aug 6, 2019

dobooth added 4 commits Aug 7, 2019

@dobooth dobooth requested a review from dshevtsov Aug 7, 2019

@dobooth dobooth changed the title Converting the Change Increment Id KB to devdocs Converting the Change Increment ID KB to devdocs Aug 7, 2019

@dshevtsov

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@dobooth did you check the topics with rake check?

dobooth added 2 commits Aug 9, 2019
@dshevtsov
Copy link
Contributor

left a comment

General: The topics for 2.2 and 2.3 are identical. Is there a reason to not create a symlink?

Also, see my review comments to the changed files.


1. Find stores and entities for which the new increment ID should be changed.
1. Connect to your MySQL DB.
For Magento Commerce (Cloud), at first, you need to SSH to your environment.

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

to SSH -> to connect using SSH

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

replace Magento Commerce (Cloud) with a variable

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Dun and Dun


## Affected versions

- Magento Commerce (on premise): 2.x.x

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

replace Magento Commerce with a variable

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Thanks

## Affected versions

- Magento Commerce (on premise): 2.x.x
- Magento Commerce (Cloud): 2.x.x

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

replace Magento Commerce (Cloud) with a variable

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Done


- Magento Commerce (on premise): 2.x.x
- Magento Commerce (Cloud): 2.x.x
- MySQL: any supported version

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

Add a link to the topic and section that lists supported versions

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Done

```

{: .bs-callout-info}
Important: The new increment value must be greater than the current one, not less.

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

remove , not less

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Nice!


The next order placed at the store with `ID=1` will have the ID '#100002000'.

## Additional recommended steps on production environments (cloud)

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

cloud -> Cloud

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 12, 2019

Contributor

Don't use cloud in parenthesis.

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Nobody puts baby in the corner.

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 12, 2019

Contributor

😜


## Additional recommended steps on production environments (cloud)

Before executing the `ALTER TABLE` query on a production environment of Magento Commerce (Cloud), we strongly recommend performing these steps:

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

replace Magento Commerce (Cloud) with a variable

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Yes


## Affected versions

- Magento Commerce (on premise): 2.x.x

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

replace Magento Commerce with a variable

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Done

## Affected versions

- Magento Commerce (on premise): 2.x.x
- Magento Commerce (Cloud): 2.x.x

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

replace Magento Commerce (Cloud) with a variable

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Converted.


- Magento Commerce (on premise): 2.x.x
- Magento Commerce (Cloud): 2.x.x
- MySQL: any supported version

This comment has been minimized.

Copy link
@dshevtsov

dshevtsov Aug 9, 2019

Contributor

add a link to the topic that lists the supported versions

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Good.

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Request Progress Aug 9, 2019

@dshevtsov dshevtsov removed their assignment Aug 9, 2019


1. Find stores and entities for which the new increment ID should be changed.
1. Connect to your MySQL DB.
For Magento Commerce (Cloud), at first, you need to SSH to your environment.

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 12, 2019

Contributor

Variable for Magento Commerce cloud is {{site.data.var.ece}}

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Thanks

- Some order records have been lost, but their IDs are already being used by payment gateways (like PayPal) for your current Merchant account. Such being the case, the payment gateways stop processing new orders that have the same IDs, returning the "Duplicate invoice id" error

{: .bs-callout-info}
You may also fix the payment gateway issue for PayPal by allowing multiple payments per invoice ID in PayPal's Payment Receiving Preferences. See the Knowledge Base article: [PayPal gateway rejected request - duplicate invoice issue][] .

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 12, 2019

Contributor
Suggested change
You may also fix the payment gateway issue for PayPal by allowing multiple payments per invoice ID in PayPal's Payment Receiving Preferences. See the Knowledge Base article: [PayPal gateway rejected request - duplicate invoice issue][] .
You may also fix the payment gateway issue for PayPal by allowing multiple payments per invoice ID in PayPal's Payment Receiving Preferences. See [PayPal gateway rejected request - duplicate invoice issue][] in the _Knowledge Base_.

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Changed!


## Additional recommended steps on production environments (cloud)

Before executing the `ALTER TABLE` query on a production environment of Magento Commerce (Cloud), we strongly recommend performing these steps:

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 12, 2019

Contributor

Variable for cloud...

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Yup

- Test the entire procedure of changing the increment ID on your Staging environment
- [Create a DB backup][] to restore your Production DB in case of failure

## Related documentation

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 12, 2019

Contributor

Boo...these related sections are draining and prone to URL maintenance. I would work links in to the content where it is relevant, or remove them completely.

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

I think they are ok.


The next order placed at the store with `ID=1` will have the ID '#100002000'.

## Additional recommended steps on production environments (cloud)

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 12, 2019

Contributor

Don't use cloud in parenthesis.

- Test the entire procedure of changing the increment ID on your Staging environment
- [Create a DB backup][] to restore your Production DB in case of failure

## Related documentation

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 12, 2019

Contributor

Boo

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Keeping it.

@dobooth
Copy link
Contributor Author

left a comment

All points taken.


## Affected versions

- Magento Commerce (on premise): 2.x.x

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Done

## Affected versions

- Magento Commerce (on premise): 2.x.x
- Magento Commerce (Cloud): 2.x.x

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Converted.


- Magento Commerce (on premise): 2.x.x
- Magento Commerce (Cloud): 2.x.x
- MySQL: any supported version

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Good.

- Some order records have been lost, but their IDs are already being used by payment gateways (like PayPal) for your current Merchant account. Such being the case, the payment gateways stop processing new orders that have the same IDs, returning the "Duplicate invoice id" error

{: .bs-callout-info}
You may also fix the payment gateway issue for PayPal by allowing multiple payments per invoice ID in PayPal's Payment Receiving Preferences. See the Knowledge Base article: [PayPal gateway rejected request - duplicate invoice issue][] .

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Changed!


1. Find stores and entities for which the new increment ID should be changed.
1. Connect to your MySQL DB.
For Magento Commerce (Cloud), at first, you need to SSH to your environment.

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Thanks

SHOW TABLE STATUS FROM `{database_name}` WHERE `name` LIKE 'sequence_{entity_type}_{store_id}';
```

## Example

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Removed them.

```

{: .bs-callout-info}
Important: The new increment value must be greater than the current one, not less.

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Nice!


The next order placed at the store with `ID=1` will have the ID '#100002000'.

## Additional recommended steps on production environments (cloud)

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Nobody puts baby in the corner.


## Additional recommended steps on production environments (cloud)

Before executing the `ALTER TABLE` query on a production environment of Magento Commerce (Cloud), we strongly recommend performing these steps:

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Yes

- Test the entire procedure of changing the increment ID on your Staging environment
- [Create a DB backup][] to restore your Production DB in case of failure

## Related documentation

This comment has been minimized.

Copy link
@dobooth

dobooth Aug 12, 2019

Author Contributor

Keeping it.

@dobooth dobooth requested review from hguthrie and dshevtsov Aug 12, 2019

@dshevtsov

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

General: The topics for 2.2 and 2.3 are identical. Is there a reason to not create a symlink?

@dobooth

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Yes, because I couldn't get the symlink to work correctly. So I made a separate topic, which will go away soon enough.

@dshevtsov

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@dobooth what was the issue with symlink?

@dobooth

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

'User error' I'm sure.

dobooth and others added 2 commits Aug 15, 2019

@m2-community-project m2-community-project bot moved this from Changes Requested to Reviewer Approved in Pull Request Progress Aug 15, 2019

@dobooth

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

running tests

@dobooth dobooth merged commit 72793ad into master Aug 15, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 15, 2019

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Aug 15, 2019

@dobooth dobooth deleted the db_kb_conversion branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.