Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about the TrimInput widget #5135

Merged

Conversation

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Aug 7, 2019

@devops-devdocs

This comment has been minimized.

Copy link

commented Aug 7, 2019

An admin must run tests on this PR before it can be merged.

@rogyar
rogyar approved these changes Aug 7, 2019
@dobooth
Copy link
Contributor

left a comment

Thanks for the excellent contribution. One small change: I would like to see the file name changed to lowercase. 'widget-trim-input.md`

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Request Progress Aug 7, 2019

@serhiyzhovnir

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

Hi @dobooth
The file name is changed.
Thank you!

@jcalcaben jcalcaben moved this from Changes Requested to Ready for Review in Pull Request Progress Aug 8, 2019

dobooth added 2 commits Aug 13, 2019
@dobooth

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

running tests

@dobooth

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

running tests

@dobooth dobooth merged commit b6c25ab into magento:master Aug 13, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 13, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Ready for Review to Done in Pull Request Progress Aug 13, 2019

@meker12 meker12 removed the Technical label Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.