Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting the Grouped Products KB to Devdocs #5155

Merged
merged 11 commits into from Aug 19, 2019

Conversation

@erikmarr
Copy link
Contributor

commented Aug 9, 2019

Purpose of this pull request

This pull request (PR) converts a KB article into a devdoc.

Affected DevDocs pages

whatsnew
Added a tutorial about how to create a grouped product using the REST API.

@erikmarr erikmarr requested a review from keharper Aug 9, 2019

@erikmarr erikmarr self-assigned this Aug 9, 2019

@m2-community-project m2-community-project bot added this to Review in Progress in Pull Request Progress Aug 9, 2019

erikmarr added 2 commits Aug 15, 2019
- label: Create and manage grouped products
class: tutorial
url: /rest/tutorials/grouped-product/create-and-manage-grouped-products.html
include_versions: ["2.3"]

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor

Delete this line. The procedure is applicable to 2.2.

- Integration
---

A grouped product consists of simple standalone products that are presented as a group. You can offer variations of a single product, or group them by season or theme.

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor
Suggested change
A grouped product consists of simple standalone products that are presented as a group. You can offer variations of a single product, or group them by season or theme.
A grouped product consists of simple standalone products that are presented as a group. A group can contain variations of a single product or a collection of products that are to be sold together.

`catalogProductRepositoryV1`

### Service endpoint

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor
Suggested change
### Service endpoint
### Endpoint

## 1. Create an empty grouped product

### Service name

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor

Delete the Service name section globally

@@ -0,0 +1,249 @@
---

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor

Move this topic to the 2.2 directory and create a symlink.


![New grouped product]({{ page.baseurl }}/rest/images/new-grouped-product.png)

You also can use the `DELETE` endpoint to delete a simple product from the group product:

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor

Move this sentence and example to the intro of this step. Make make it a Tip.

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor

Add a sentence saying you've completed this tutorial.

This comment has been minimized.

Copy link
@erikmarr

erikmarr Aug 16, 2019

Author Contributor

I moved the delete sentence to after the response of the previous step not the intro.


`DELETE /V1/products/{sku}/links/{type}/{linkedProductSku}`

## 4. Add a grouped product to a cart

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor
Suggested change
## 4. Add a grouped product to a cart
Add a grouped product to a cart

## 4. Add a grouped product to a cart

You can now add this grouped product to a customer's cart.

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor

Replace this sentence with something like:

Customers can now add this grouped products to their carts, as shown below.

Move the "Refer" paragraph below to here.

}
```

Refer to the [Order processing tutorial]({{ page.baseurl }}/rest/tutorials/orders/order-intro.html) for more information about how to add items to a cart via REST.

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor
Suggested change
Refer to the [Order processing tutorial]({{ page.baseurl }}/rest/tutorials/orders/order-intro.html) for more information about how to add items to a cart via REST.
Refer to the [Order processing tutorial]({{ page.baseurl }}/rest/tutorials/orders/order-intro.html) for more information about how to add items to a cart with REST.

Refer to the [Order processing tutorial]({{ page.baseurl }}/rest/tutorials/orders/order-intro.html) for more information about how to add items to a cart via REST.

## Related endpoints

This comment has been minimized.

Copy link
@keharper

keharper Aug 15, 2019

Contributor

Delete this section.

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Request Progress Aug 15, 2019

@keharper
Copy link
Contributor

left a comment

Approved, pending one change.


![New grouped product]({{ page.baseurl }}/rest/images/new-grouped-product.png)

## Congratulations! You've finished.

This comment has been minimized.

Copy link
@keharper

keharper Aug 16, 2019

Contributor

Since this is a one page tutorial, let's delete the Congrats section.

erikmarr added 2 commits Aug 19, 2019
@erikmarr

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

running tests

@erikmarr erikmarr merged commit 69c80d2 into master Aug 19, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 19, 2019

Hi @erikmarr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Changes Requested to Done in Pull Request Progress Aug 19, 2019

@erikmarr erikmarr deleted the em_kbconversion-restapi branch Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.