Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional information on how to include 3rd-party JS libraries #5161

Merged
merged 5 commits into from Aug 13, 2019

Conversation

@eduard13
Copy link
Contributor

commented Aug 11, 2019

Purpose of this pull request

This pull request (PR) describes how a 3rd party JS Library can be included and used within the entire website.

Affected DevDocs pages

whatsnew
Updated the JavaScript resources topic with instructions for including third-party JavaScript libraries.

@devops-devdocs

This comment has been minimized.

Copy link

commented Aug 11, 2019

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Aug 11, 2019

@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 11, 2019

@rogyar

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

Hi @eduard13. Thank you for your collaboration. From a technical perspective, your point is correct.
I would put a new library into a custom module instead of a custom theme since it's much easier to disable/remove a module than editing the theme.
However, both ways are working and commonly used.

Small adjustment
Co-Authored-By: Yaroslav Rogoza <enarc@atwix.com>
@eduard13

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2019

Hi @rogyar, thank you for the review, the requested changes were applied.

@rogyar
rogyar approved these changes Aug 12, 2019
dobooth added 2 commits Aug 12, 2019

@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Aug 12, 2019

@dobooth

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

running tests

@dobooth dobooth merged commit df300f4 into magento:master Aug 13, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 13, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.