Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/devdocs#: Data Migration Tool. Data migration command. Preparation for delta step. #5167

Merged
merged 4 commits into from Aug 14, 2019

Conversation

@atwixfirster
Copy link
Contributor

commented Aug 12, 2019

Purpose of this pull request

This pull request (PR) adds information about back-end processes when customer runs

bin/magento migrate:data

command.

Affected DevDocs pages

Links to Magento source code

Thank you!

whatsnew
Provided details about what happens when you run the Data Migration Tool.

@devops-devdocs

This comment has been minimized.

Copy link

commented Aug 12, 2019

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Aug 12, 2019

@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 12, 2019

@rogyar

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Hi @atwixfirster. Thank you for providing that information. Considering the fact, that the raw SQL requests might be harder to understand for some people in comparison with the simplified verbal explanation, we should introduce both explanations: simple and extended.

So, my suggestion is to put a few sentences about how the process works. For example:

Additional tables will contain information about the changed records after the last migration execution. The database triggers are used to fill these extra tables, so once a new operation is being performed on the particular table (a record is added/modified/removed), the database trigger added by the Migration Tool saves information about this operation to the extra table.
If we run a delta migration process, the Tool checks these tables for the unprocessed records and ...

and put the details in SQL queries format below. So we have a polished rock-solid explanation of the process :)

Thank you!

@rogyar
Copy link
Contributor

left a comment

Please, check my suggestion above.

@jeff-matthews jeff-matthews requested a review from victor-v-rad Aug 12, 2019

@atwixfirster

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Please, check my suggestion above.

@rogyar , your suggestions have been implemented.

Could you please verify?

Many thanks!

@rogyar
rogyar approved these changes Aug 13, 2019
Copy link
Contributor

left a comment

Awesome, thank you.

dobooth added 2 commits Aug 14, 2019
@dobooth

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

running tests

@dobooth dobooth merged commit d1acfad into magento:master Aug 14, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 14, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Review in Progress to Done in Pull Request Progress Aug 14, 2019

@meker12

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

@dobooth Missing whatsnew on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.