Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about PopupWindow widget #5171

Conversation

@serhiyzhovnir
Copy link
Contributor

commented Aug 12, 2019

@devops-devdocs

This comment has been minimized.

Copy link

commented Aug 12, 2019

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Aug 12, 2019

@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 12, 2019

@rogyar
rogyar approved these changes Aug 12, 2019
Copy link
Contributor

left a comment

Hi @serhiyzhovnir. Thank you for updating the PR

@dobooth dobooth self-assigned this Aug 12, 2019

@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Aug 12, 2019

@dobooth

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

running tests

@dobooth dobooth merged commit be2d25f into magento:master Aug 12, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 12, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Aug 12, 2019

@meker12

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@dobooth This PR is missing the whatsnew, which is required for new topics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.