Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding and additional section of how to move a checkout component #5225

Merged
merged 6 commits into from Aug 26, 2019

Conversation

@eduard13
Copy link
Contributor

commented Aug 21, 2019

Purpose of this pull request

This pull request (PR) adds an additional section to Customize Checkout page, by showing how to move components within the page.

Affected DevDocs pages

Links to Magento source code

  • ...

whatsnew
Added new code examples to the Customize Checkout tutorial.

@devops-devdocs

This comment has been minimized.

Copy link

commented Aug 21, 2019

An admin must run tests on this PR before it can be merged.

@osrecio osrecio self-assigned this Aug 21, 2019

@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 21, 2019

@osrecio
Copy link
Member

left a comment

From the technical point of view this PR is valid.

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Request Progress Aug 23, 2019

@eduard13

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

Hey @jeff-matthews thank you for the suggestions, could you please check the latest updates?

@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Request Progress Aug 24, 2019

@eduard13

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

@keharper the changes were updated.
Thank you.

@jeff-matthews jeff-matthews moved this from Review in Progress to Reviewer Approved in Pull Request Progress Aug 26, 2019

@jeff-matthews jeff-matthews moved this from Reviewer Approved to Acceptance Testing in Pull Request Progress Aug 26, 2019

@jeff-matthews
Copy link
Contributor

left a comment

@eduard13, I just noticed some markdown syntax errors on your branch that will fail tests. Please fix the following issues so that I can finish processing your PR:

rake test:cicd
Testing Markdown style with mdl ...
guides/v2.2/howdoi/checkout/checkout_customize.md:99: MD009 Trailing spaces
guides/v2.2/howdoi/checkout/checkout_customize.md:137: MD009 Trailing spaces
guides/v2.3/howdoi/checkout/checkout_customize.md:99: MD009 Trailing spaces
guides/v2.3/howdoi/checkout/checkout_customize.md:137: MD009 Trailing spaces

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

The Markdown linter has found 6 issues``` 
@eduard13

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@jeff-matthews, have just removed them. Thank you for informing.

@jeff-matthews
Copy link
Contributor

left a comment

Confirmed. Thanks @eduard13!

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

running tests

@jeff-matthews jeff-matthews merged commit bbf80a0 into magento:master Aug 26, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 26, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Acceptance Testing to Done in Pull Request Progress Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.