Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/devdocs#: Get di.xml info for the particular class #5269

Merged
merged 5 commits into from Aug 26, 2019

Conversation

@atwixfirster
Copy link
Contributor

commented Aug 25, 2019

Purpose of this pull request

This pull request (PR) adds information how to retrieve Dependency Injection configuration information for the particular class.

Affected DevDocs pages

Links to Magento source code

Thank you!

whatsnew
Added information about how to retrieve dependency injection configuration information for a particular class.

@devops-devdocs

This comment has been minimized.

Copy link

commented Aug 25, 2019

An admin must run tests on this PR before it can be merged.

@atwixfirster atwixfirster changed the title magento/devdocs#: Get di.xml for the particular class magento/devdocs#: Get di.xml info for the particular class Aug 25, 2019

@rogyar rogyar self-assigned this Aug 25, 2019

@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 25, 2019

@rogyar

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Hi @atwixfirster. Thanks a lot for the great addition

@rogyar
rogyar approved these changes Aug 26, 2019

@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Aug 26, 2019

@jeff-matthews jeff-matthews moved this from Changes Requested to Reviewer Approved in Pull Request Progress Aug 26, 2019

@jeff-matthews jeff-matthews moved this from Reviewer Approved to Acceptance Testing in Pull Request Progress Aug 26, 2019

@jeff-matthews
Copy link
Contributor

left a comment

@atwixfirster, I just noticed some markdown syntax errors on your branch that are causing tests to fail:

Sorry, I used the wrong contributor name to notify you about this. I edited this comment to correct it.

rake test:cicd
Testing Markdown style with mdl ...
guides/v2.2/extension-dev-guide/build/di-xml-file.md:357: MD009 Trailing spaces
guides/v2.2/extension-dev-guide/build/di-xml-file.md:362: MD009 Trailing spaces
guides/v2.2/extension-dev-guide/build/di-xml-file.md:397: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/build/di-xml-file.md:357: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/build/di-xml-file.md:362: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/build/di-xml-file.md:397: MD009 Trailing spaces

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

The Markdown linter has found 8 issues``` 
@atwixfirster

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

I just noticed some markdown syntax errors on your branch that are causing tests to fail:

fixed

@jeff-metthews, could you please run tests again?

Thank you!

@jeff-matthews
Copy link
Contributor

left a comment

Confirmed. Thanks @atwixfirster!

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

running tests

@jeff-matthews jeff-matthews merged commit 66cd2a5 into magento:master Aug 26, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 26, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Acceptance Testing to Done in Pull Request Progress Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.