Added the RemainingCharacters widget documentation #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
m2-community-project
bot
moved this from Ready for Review
to Review in Progress
in Pull Request Progress
rogyar
suggested changes
Sep 23, 2019
|
|
||
| ### `noteSelector` | ||
|
|
||
| The selector of note element. |
There was a problem hiding this comment.
Hi @serhiyzhovnir. Thank you for the great topic!
Could you add more info about the note element, please? At first glance, it's not completely clear what's the note component and its main purpose.
Thank you!
|
Hi @rogyar |
|
Awesome, thank you! |
rogyar
approved these changes
Sep 24, 2019
dobooth
approved these changes
Sep 24, 2019
m2-community-project
bot
moved this from Review in Progress
to Reviewer Approved
in Pull Request Progress
|
running tests |
|
Hi @serhiyzhovnir, thank you for your contribution! |
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds the documentation for the RemainingCharacters widget.
Affected DevDocs pages
Links to Magento source code
whatsnew
Added the RemainingCharacters widget topic to the Javascript Developer Guide.