Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compression from generate to transfer (#191853) #413

Merged
merged 1 commit into from Jan 30, 2019

Conversation

@rglepper
Copy link
Contributor

commented Jan 25, 2019

Description

When generating JS bundles or other front-end assets during the build stage the compression happens too early and the generated code isn’t compressed. This commit fixes it by moving the compression to the beginning of the transfer step

Fixed Issues (if relevant)

Magento cloud support ticket #191853

Manual testing scenarios

No manual tests.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
Move compression from generate to transfer (#191853)
When generating JS bundles or other front-end assets during the build stage the compression happens too early and the generated code isn’t compressed. This commit fixes it by moving the compression to the beginning of the transfer step
@magento-cicd2

This comment has been minimized.

Copy link

commented Jan 25, 2019

CLA assistant check
All committers have signed the CLA.

@shiftedreality

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

Hello @rglepper,

Thank you for your contribution! We will process it shortly.

@YPyltiai
Copy link
Contributor

left a comment

Approved from PM's side.
Please proceed with merge once tested.

@andriyShevtsov

This comment has been minimized.

Copy link
Collaborator

commented Jan 30, 2019

QA approved

@shiftedreality shiftedreality merged commit ace5afe into magento:develop Jan 30, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Jan 30, 2019

Hi @rglepper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@andriyShevtsov

This comment has been minimized.

Copy link
Collaborator

commented Feb 8, 2019

Internal ticket is MAGECLOUD-3104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.