Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGECLOUD-2822: An error appears on SCD if it runs in parallel: Error while waiting for package deployed #418

Merged
merged 11 commits into from Apr 2, 2019

Conversation

@oshmyheliuk
Copy link
Contributor

@oshmyheliuk oshmyheliuk commented Feb 14, 2019

Description

Fixed Issues (if relevant)

https://magento2.atlassian.net/browse/MAGECLOUD-2822

Manual testing scenarios

https://jira.corp.magento.com/browse/MAGECLOUD-101

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@andriyShevtsov
Copy link
Contributor

@andriyShevtsov andriyShevtsov commented Mar 29, 2019

QA passed

Loading

@andriyShevtsov
Copy link
Contributor

@andriyShevtsov andriyShevtsov commented Mar 29, 2019

Validation was added. Retested again. QA approved

Loading

@@ -58,6 +58,17 @@
# deploy: #
# SCD_STRATEGY: "compact" #
#######################################################################################################################
# SCD_MAX_EXECUTION_TIME - allows you to increase maximum expected execution time of static content deploy command. #
Copy link
Contributor

@meker12 meker12 Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# SCD_MAX_EXECUTION_TIME - allows you to increase maximum expected execution time of static content deploy command. #
# SCD_MAX_EXECUTION_TIME - allows you to increase the maximum expected execution time for the static content deploy command. #

Loading

Copy link
Contributor Author

@oshmyheliuk oshmyheliuk Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Loading

@@ -58,6 +58,17 @@
# deploy: #
# SCD_STRATEGY: "compact" #
#######################################################################################################################
# SCD_MAX_EXECUTION_TIME - allows you to increase maximum expected execution time of static content deploy command. #
# By default in Magento this value is set to 400 seconds but in some scenarios #
Copy link
Contributor

@meker12 meker12 Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, Magento Commerce sets the maximum expected execution to 400 seconds, but in some scenarios you might need more time to complete the static content deployment for a Cloud project.

Loading

Copy link
Contributor Author

@oshmyheliuk oshmyheliuk Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thank you.

Loading

@shiftedreality
Copy link
Member

@shiftedreality shiftedreality commented Apr 2, 2019

Non-functional changes added. Approved.

Loading

@shiftedreality shiftedreality merged commit 693e88b into magento:develop Apr 2, 2019
2 checks passed
Loading
@contribution-survey
Copy link

@contribution-survey contribution-survey bot commented Apr 2, 2019

Hi @oshmyheliuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants