Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGECLOUD-2822: An error appears on SCD if it runs in parallel: Error while waiting for package deployed #418

Merged
merged 11 commits into from Apr 2, 2019

Conversation

Projects
None yet
7 participants
@oshmyheliuk
Copy link
Collaborator

commented Feb 14, 2019

Description

Fixed Issues (if relevant)

https://magento2.atlassian.net/browse/MAGECLOUD-2822

Manual testing scenarios

https://jira.corp.magento.com/browse/MAGECLOUD-101

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@NadiyaS NadiyaS added the onhold label Feb 14, 2019

oshmyheliuk added some commits Feb 15, 2019

@NadiyaS NadiyaS added review and removed onhold labels Mar 28, 2019

@NadiyaS NadiyaS added qa and removed review labels Mar 28, 2019

@andriyShevtsov

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

QA passed

@andriyShevtsov

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

Validation was added. Retested again. QA approved

@shiftedreality shiftedreality added approved and removed review labels Mar 29, 2019

@@ -58,6 +58,17 @@
# deploy: #
# SCD_STRATEGY: "compact" #
#######################################################################################################################
# SCD_MAX_EXECUTION_TIME - allows you to increase maximum expected execution time of static content deploy command. #

This comment has been minimized.

Copy link
@meker12

meker12 Apr 1, 2019

Suggested change
# SCD_MAX_EXECUTION_TIME - allows you to increase maximum expected execution time of static content deploy command. #
# SCD_MAX_EXECUTION_TIME - allows you to increase the maximum expected execution time for the static content deploy command. #

This comment has been minimized.

Copy link
@oshmyheliuk

oshmyheliuk Apr 1, 2019

Author Collaborator

Fixed.

@@ -58,6 +58,17 @@
# deploy: #
# SCD_STRATEGY: "compact" #
#######################################################################################################################
# SCD_MAX_EXECUTION_TIME - allows you to increase maximum expected execution time of static content deploy command. #
# By default in Magento this value is set to 400 seconds but in some scenarios #

This comment has been minimized.

Copy link
@meker12

meker12 Apr 1, 2019

By default, Magento Commerce sets the maximum expected execution to 400 seconds, but in some scenarios you might need more time to complete the static content deployment for a Cloud project.

This comment has been minimized.

Copy link
@oshmyheliuk

oshmyheliuk Apr 1, 2019

Author Collaborator

Fixed, thank you.

oshmyheliuk added some commits Apr 1, 2019

@shiftedreality

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Non-functional changes added. Approved.

@shiftedreality shiftedreality merged commit 693e88b into magento:develop Apr 2, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Apr 2, 2019

Hi @oshmyheliuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@shiftedreality shiftedreality deleted the magento-thunder:MAGECLOUD-2822 branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.