Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Expand createEmptyCart mutation #607

Closed
naydav opened this issue Apr 12, 2019 · 4 comments
Closed

Expand createEmptyCart mutation #607

naydav opened this issue Apr 12, 2019 · 4 comments
Assignees
@anzin @bohdan-harniuk
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Milestone
Release: 2.3.2

Comments

@naydav
Copy link
Contributor

naydav commented Apr 12, 2019 •
edited

Examples:
https://github.com/magento/graphql-ce/blob/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/CreateEmptyCartTest.php

https://github.com/magento/graphql-ce/blob/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/CreateEmptyCartTest.php
@naydav naydav added good first issue Good for newcomers Contribution Day Tickets is good for start on Contribution Day labels Apr 12, 2019
@naydav naydav added this to the Release: 2.3.2 milestone Apr 12, 2019
@bohdan-harniuk bohdan-harniuk self-assigned this Apr 13, 2019
@anzin anzin self-assigned this Apr 13, 2019
anzin pushed a commit to anzin/graphql-ce that referenced this issue Apr 13, 2019
magento#607: Expanded "createdEmptyCart" mutation with not required p…
c50c01e 
…arameter "cart_id"
@anzin anzin mentioned this issue Apr 13, 2019
Merged
anzin pushed a commit to anzin/graphql-ce that referenced this issue Apr 13, 2019
magento#607: Fixed own mistake
9874b4e
@anzin
Copy link

anzin commented Apr 15, 2019

@naydav, can you help me ?
How to validate cart_id? The length should be equal to 32, as in the standard implementation: http://joxi.ru/Dr8M0GMtozdgEm ? Or can it be smaller?

bohdan-harniuk pushed a commit to anzin/graphql-ce that referenced this issue Apr 15, 2019
magento#607: Added testing for the next guest scenarios: creating emp…
e346a92 
…ty cart with specified "cart_id", specified "cart_id" NOT unique
bohdan-harniuk pushed a commit to anzin/graphql-ce that referenced this issue Apr 16, 2019
magento#607: added validation on "cart_id" length and changed impleme…
82c5536 
…ntation by using data provider for validation
bohdan-harniuk pushed a commit to anzin/graphql-ce that referenced this issue Apr 16, 2019
magento#607: Merged with magento/graphql-ce:2.3-develop
f2d14b8
bohdan-harniuk pushed a commit to anzin/graphql-ce that referenced this issue Apr 16, 2019
magento#607: Changed graphql request type from get to post
39cabae
bohdan-harniuk pushed a commit to anzin/graphql-ce that referenced this issue Apr 16, 2019
magento#607: Added tests for creating empty cart by customers
4dd5005
bohdan-harniuk pushed a commit to anzin/graphql-ce that referenced this issue Apr 16, 2019
magento#607: Refactored tests for creating empty cart by guests
53b5341
bohdan-harniuk pushed a commit to anzin/graphql-ce that referenced this issue Apr 16, 2019
magento#607: Fixed issue with wrong length calculation for hash
35bebde
@naydav
Copy link
Contributor Author

naydav commented Apr 16, 2019 •
edited

@naydav, can you help me ?
How to validate cart_id? The length should be equal to 32, as in the standard implementation: http://joxi.ru/Dr8M0GMtozdgEm ? Or can it be smaller?

yes + \w\d+
Thanks

@anzin
Copy link

anzin commented Apr 17, 2019

@naydav , Thanks a lot for your help

naydav pushed a commit to anzin/graphql-ce that referenced this issue Apr 19, 2019
@naydav
magento#607: Expanded "createdEmptyCart" mutation with not required p…
b82d771 
…arameter "cart_id"
naydav pushed a commit to anzin/graphql-ce that referenced this issue Apr 19, 2019
@naydav
magento#607: Fixed own mistake
38f473c
@naydav
Copy link
Contributor Author

naydav commented Apr 22, 2019

#610

@naydav naydav closed this as completed Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anzin anzin

@bohdan-harniuk bohdan-harniuk

Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.2
Development

No branches or pull requests
3 participants
@naydav @anzin @bohdan-harniuk