This repository was archived by the owner on Dec 19, 2019. It is now read-only.
Customer downloadable products GraphQL#802
Merged
magento-engcom-team merged 19 commits into2.3-developfrom Aug 29, 2019
Merged
Conversation
lenaorobei
suggested changes
Aug 5, 2019
| "description": "N/A", | ||
| "type": "magento2-module", | ||
| "require": { | ||
| "php": "~7.1.3||~7.2.0", |
Contributor
There was a problem hiding this comment.
Suggested change
| "php": "~7.1.3||~7.2.0", | |
| "php": "~7.1.3||~7.2.0||~7.3.0", |
| status: String | ||
| download_url: String | ||
| remaining_downloads: String | ||
| } No newline at end of file |
| * @magentoApiDataFixture Magento/Downloadable/_files/product_downloadable.php | ||
| * @magentoApiDataFixture Magento/Downloadable/_files/order_with_downloadable_product.php | ||
| */ | ||
| public function testGetCustomerDownloadableProducts() |
Contributor
There was a problem hiding this comment.
This test can be simplified. Please have a look at \Magento\GraphQl\Downloadable\CustomerDownloadableProductsTest::testCustomerDownloadableProducts.
Contributor
Author
|
@lenaorobei I changed the things that you mentioned, please check. |
Contributor
Contributor
Author
|
@lenaorobei that's done. |
…CustomerDownloadableGraphQl
…le into new one - added composer dependency - removed some hard dependencies because of DependencyTest bug MC-19635
…le into new one - removed composer dependency because of DependencyTest bug MC-19635
lenaorobei
approved these changes
Aug 27, 2019
Contributor
|
Hi @lenaorobei, thank you for the review.
|
Contributor
|
@magento run Functional Tests build |
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 29, 2019
|
Hi @ldusan84, thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Moved customer downloadable products into a new module and added tests.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)