Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer downloadable products GraphQL #802

Open
wants to merge 15 commits into
base: 2.3-develop
from

Conversation

@ldusan84
Copy link
Contributor

commented Aug 5, 2019

Description (*)

Moved customer downloadable products into a new module and added tests.

Fixed Issues (if relevant)

  1. #685: Extract logic related to customer from DownloadableGraphQl module into new one

Manual testing scenarios (*)

  1. Get token as customer:
mutation {
  generateCustomerToken(
    email: "customer@example.com"
    password: "password"
  ) {
    token
  }
}
  1. Get customer's downloadable products:
{
    customerDownloadableProducts{
        items{
            order_increment_id
            date
            status
            download_url
            remaining_downloads
        }
    }
}

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Aug 5, 2019

@lenaorobei
Copy link
Contributor

left a comment

Please address my comments and remove duplicated tests \Magento\GraphQl\Downloadable\CustomerDownloadableProductsTest.

"description": "N/A",
"type": "magento2-module",
"require": {
"php": "~7.1.3||~7.2.0",

This comment has been minimized.

Copy link
@lenaorobei

lenaorobei Aug 5, 2019

Contributor
Suggested change
"php": "~7.1.3||~7.2.0",
"php": "~7.1.3||~7.2.0||~7.3.0",
status: String
download_url: String
remaining_downloads: String
}

This comment has been minimized.

Copy link
@lenaorobei

lenaorobei Aug 5, 2019

Contributor
Suggested change
}
}
* @magentoApiDataFixture Magento/Downloadable/_files/product_downloadable.php
* @magentoApiDataFixture Magento/Downloadable/_files/order_with_downloadable_product.php
*/
public function testGetCustomerDownloadableProducts()

This comment has been minimized.

Copy link
@lenaorobei

lenaorobei Aug 5, 2019

Contributor

This test can be simplified. Please have a look at \Magento\GraphQl\Downloadable\CustomerDownloadableProductsTest::testCustomerDownloadableProducts.

@m2-community-project m2-community-project bot moved this from Ready for Review to Changes Requested in Pull Request Progress Aug 5, 2019

@ldusan84

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

@lenaorobei I changed the things that you mentioned, please check.

@lenaorobei

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@ldusan84 could you please pull latest mainline changes. We delivered recently #412 and it will impact your PR.

ldusan84 added some commits Aug 16, 2019

@ldusan84

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

@lenaorobei that's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.