graphQl-914: [Customer] Improve consistency of country field in custo… #958

kisroman · 2019-09-23T10:03:34Z

…mer address

Description (*)

Fixed Issues (if relevant)

[Customer] Improve consistency of country field in customer address #914

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…mer address

lenaorobei · 2019-09-27T13:10:57Z

app/code/Magento/CustomerGraphQl/etc/schema.graphqls

@@ -28,7 +28,8 @@ input CustomerAddressInput {
    city: String @doc(description: "The city or town")
    region: CustomerAddressRegionInput @doc(description: "An object containing the region name, region code, and region ID")
    postcode: String @doc(description: "The customer's ZIP or postal code")
-    country_id: CountryCodeEnum @doc(description: "The customer's country")
+    country_id: CountryCodeEnum @doc(description: "The customer's country") @deprecated(reason: "Use country_code instead.")


Suggested change

country_id: CountryCodeEnum @doc(description: "The customer's country") @deprecated(reason: "Use country_code instead.")

country_id: CountryCodeEnum @doc(description: "Deprecated: Use `country_code` instead")

Input types do not support @deprecated directive.

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/CreateCustomerAddressTest.php

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerAddressTest.php

app/code/Magento/CustomerGraphQl/Model/Customer/Address/CreateCustomerAddress.php

lenaorobei

Please pull latest 2.3-develop and address found issues. Thank you.

# Conflicts: # app/code/Magento/CustomerGraphQl/etc/schema.graphqls

…mer address

magento-engcom-team · 2019-10-07T08:58:35Z

Hi @lenaorobei, thank you for the review.
ENGCOM-6027 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerAddressTest.php

lenaorobei

Please see minor issues.

…mer address

magento-engcom-team · 2019-10-16T16:11:41Z

Hi @lenaorobei, thank you for the review.
ENGCOM-6027 has been created to process this Pull Request

…ield in custo… #958

ghost · 2019-10-23T20:01:45Z

Hi @kisroman, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

TomashKhamlai · 2019-11-01T13:41:30Z

@lenaorobei is it a milestone 2.3.4?

graphQl-914: [Customer] Improve consistency of country field in custo…

17fa6d9

…mer address

kisroman requested a review from paliarush as a code owner September 23, 2019 10:03

magento-engcom-team added Community Insider: Magecom community-insider-contribution labels Sep 23, 2019

m2-community-project bot added this to Ready for Review in Pull Request Progress Sep 23, 2019

lenaorobei reviewed Sep 27, 2019

View reviewed changes

m2-community-project bot assigned lenaorobei Sep 27, 2019

m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Sep 27, 2019

m2-community-project bot added the Progress: review label Sep 27, 2019

lenaorobei reviewed Sep 27, 2019

View reviewed changes

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/CreateCustomerAddressTest.php Show resolved Hide resolved

lenaorobei reviewed Sep 27, 2019

View reviewed changes

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerAddressTest.php Outdated Show resolved Hide resolved

lenaorobei reviewed Sep 27, 2019

View reviewed changes

app/code/Magento/CustomerGraphQl/Model/Customer/Address/CreateCustomerAddress.php Show resolved Hide resolved

lenaorobei suggested changes Oct 1, 2019

View reviewed changes

lenaorobei added the Progress: needs update label Oct 1, 2019

lenaorobei moved this from Review in Progress to Changes Requested in Pull Request Progress Oct 1, 2019

m2-community-project bot added Progress: changes requested and removed Progress: needs update Progress: review labels Oct 1, 2019

kisroman added 2 commits October 3, 2019 13:33

Merge branch '2.3-develop' into graphQl-914

42ecae6

# Conflicts: # app/code/Magento/CustomerGraphQl/etc/schema.graphqls

graphQl-914: [Customer] Improve consistency of country field in custo…

fd7522f

…mer address

lenaorobei approved these changes Oct 7, 2019

View reviewed changes

magento-engcom-team added Release Line: 2.3 Component: CustomerGraphQl labels Oct 7, 2019

lenaorobei added Progress: accept Auto-Tests: Covered labels Oct 10, 2019

lenaorobei reviewed Oct 10, 2019

View reviewed changes

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerAddressTest.php Outdated Show resolved Hide resolved

lenaorobei reviewed Oct 10, 2019

View reviewed changes

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerAddressTest.php Show resolved Hide resolved

lenaorobei suggested changes Oct 10, 2019

View reviewed changes

lenaorobei removed the Progress: accept label Oct 10, 2019

lenaorobei added the Progress: needs update label Oct 10, 2019

keharper added the requires-documentation label Oct 15, 2019

magento#914: [Customer] Improve consistency of country field in custo…

1e5defb

…mer address

TomashKhamlai added the QA in progress We are checking label Oct 16, 2019

magento#914: [Customer] Improve consistency of country field in custo…

21749cc

…mer address

TomashKhamlai added QA passed and removed QA in progress We are checking labels Oct 16, 2019

lenaorobei approved these changes Oct 16, 2019

View reviewed changes

lenaorobei added Progress: accept and removed Progress: needs update labels Oct 16, 2019

magento-engcom-team pushed a commit that referenced this pull request Oct 23, 2019

ENGCOM-6027: graphQl-914: [Customer] Improve consistency of country f…

6cc991c

…ield in custo… #958

magento-engcom-team merged commit 21749cc into magento:2.3-develop Oct 23, 2019

m2-community-project bot moved this from Changes Requested to Done in Pull Request Progress Oct 23, 2019

m2-community-project bot removed Progress: accept Progress: changes requested labels Oct 23, 2019

keharper mentioned this pull request Oct 24, 2019

GraphQL: Deprecate attributes from Engcomm PRs magento/devdocs#5838

Merged

keharper added documentation-completed and removed requires-documentation labels Oct 25, 2019

TomashKhamlai mentioned this pull request Nov 1, 2019

Misleading country_code field and missing vat_id in graphql mutation schema #1045

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

graphQl-914: [Customer] Improve consistency of country field in custo… #958

graphQl-914: [Customer] Improve consistency of country field in custo… #958

kisroman commented Sep 23, 2019

lenaorobei Sep 27, 2019

kisroman Oct 3, 2019

lenaorobei left a comment

magento-engcom-team commented Oct 7, 2019

lenaorobei left a comment

magento-engcom-team commented Oct 16, 2019

ghost commented Oct 23, 2019

TomashKhamlai commented Nov 1, 2019

	country_id: CountryCodeEnum @doc(description: "The customer's country") @deprecated(reason: "Use country_code instead.")
	country_id: CountryCodeEnum @doc(description: "Deprecated: Use `country_code` instead")

graphQl-914: [Customer] Improve consistency of country field in custo… #958

graphQl-914: [Customer] Improve consistency of country field in custo… #958

Conversation

kisroman commented Sep 23, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

lenaorobei Sep 27, 2019

Choose a reason for hiding this comment

kisroman Oct 3, 2019

Choose a reason for hiding this comment

lenaorobei left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Oct 7, 2019

lenaorobei left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Oct 16, 2019

ghost commented Oct 23, 2019

TomashKhamlai commented Nov 1, 2019