Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCLOUD-5981: Added GNUPG extension #210

Merged
merged 4 commits into from May 21, 2020

Conversation

G-Arvind
Copy link
Contributor

@G-Arvind G-Arvind commented May 11, 2020

Description

Added GNUPG extension to PHP images.

Fixed Issues (if relevant)

https://jira.corp.magento.com/browse/MCLOUD-5981

  1. MCLOUD-5981: How to Install and Configure Gnupg ? #177: How to Install and Configure Gnupg

Manual testing scenarios

  1. Run php -m | grep "gnupg"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

bbatsche
bbatsche previously approved these changes May 11, 2020
@mveeramneni mveeramneni changed the title Added GNUPG extension MCLOUD-5981: Added GNUPG extension May 13, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress May 14, 2020
@andriyShevtsov
Copy link
Contributor

Failed during building php-fpm 7.3 image locally:

Removing intermediate container 9ab0b500cd98
 ---> 76629ca16d54
Step 20/38 : RUN docker-php-ext-enable   bcmath   bz2   calendar   exif   gd   geoip   gettext   gmp   gnupg   igbinary   imagick   imap   intl   ldap   mailparse   msgpack   mysqli   oauth   opcache   pcov   pdo_mysql   propro   pspell   raphf   recode   redis   shmop   soap   sockets   sodium   sysvmsg   sysvsem   sysvshm   tidy   xdebug   xmlrpc   xsl   yaml   zip   pcntl   ioncube
 ---> Running in 0587fdd6c72d
The command '/bin/sh -c docker-php-ext-enable   bcmath   bz2   calendar   exif   gd   geoip   gettext   gmp   gnupg   igbinary   imagick   imap   intl   ldap   mailparse   msgpack   mysqli   oauth   opcache   pcov   pdo_mysql   propro   pspell   raphf   recode   redis   shmop   soap   sockets   sodium   sysvmsg   sysvsem   sysvshm   tidy   xdebug   xmlrpc   xsl   yaml   zip   pcntl   ioncube' returned a non-zero code: 137

@andriyShevtsov
Copy link
Contributor

@G-Arvind please take a look

@G-Arvind
Copy link
Contributor Author

G-Arvind commented May 20, 2020

@G-Arvind please take a look

Hi @andriyShevtsov , the image got built successfully in my local.

The error code 137 which you are facing means an out of memory error. So there are chances that the build got failed due to out of memory.

Can you please try this:

docker inspect <container ID>

Review the application's memory requirements and ensure that the container it's running in has sufficient memory.
Thanks.

@YPyltiai YPyltiai added community PR/issue origin and removed question issue type labels May 20, 2020
@andriyShevtsov
Copy link
Contributor

Got it. Thank you. I will check

@andriyShevtsov
Copy link
Contributor

Also you have a merging conflict with mainline. May you please resolve it

@andriyShevtsov
Copy link
Contributor

QA approved

@shiftedreality
Copy link
Member

@G-Arvind please solve the conflicts

@G-Arvind G-Arvind dismissed stale reviews from michaelcasey316 and bbatsche via f93f4a4 May 21, 2020 04:40
@G-Arvind
Copy link
Contributor Author

Hi @shiftedreality, @bbatsche, @michaelcasey316, @andriyShevtsov fixed the conflicts by removing PHP 7.1 images.

Thanks.

@shiftedreality shiftedreality self-assigned this May 21, 2020
@shiftedreality shiftedreality merged commit ab8be2b into magento:develop May 21, 2020
Pull Request Progress automation moved this from Reviewer Approved to Done May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

8 participants