Skip to content

[CMS Team 1] Events Interfaces & Docs #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davemacaulay
Copy link
Contributor

@davemacaulay davemacaulay commented Jun 21, 2018

Scope

Story

Bamboo CI Builds

Jenkins

Checklist

  • PR is green on M2 Quality Portal
  • Jira issues have accurate summary, meaningful description and have links to relevant documentation at the story/task level
  • Semantic Version build failure is approved by architect (if build is red)
  • Pull Request approved by architect
  • Pull Request quality review performed by
  • All unstable functional acceptance tests are isolated (if any)
  • All linked Zephyr tests are approved by PO and have Ready to Use status
  • Travis CI build is green (for mainline CE only)
  • Jenkins Extended FAT build is green

- Update dev documentation for drag & drop implementation
# Conflicts:
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/products/preview.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/products/preview.ts
- Compile preview.js correctly
- Resolve import order
@davemacaulay davemacaulay merged commit ba3a657 into magento:develop Jun 21, 2018
@cspruiell cspruiell deleted the MC-1184-drag-drop-dev-docs branch September 14, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant