Update HtmlFilter.php DOM Text Interpreted As HTML

[Shivam7-1]

Description
Here innerText can be used it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML.

Checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[Shivam7-1]

Hii @engcom-Hotel Could You Please Take a look and Review Here in this PR ?
Thanks

[Shivam7-1]

@magento run all tests

[engcom-Hotel]

Hello @Shivam7-1,

Please refer to the below review comment.

Thanks

[engcom-Hotel]

Please elaborate on the purpose of this change.

Also as I can see here you are just changing the variable name. If that is so then please update the same in line number 115 and 118:

magento2-page-builder/app/code/Magento/PageBuilder/Model/Stage/HtmlFilter.php

Line 115 in 1a52ef4

$innerHTML .= $ownerDocument->saveXML($child);

magento2-page-builder/app/code/Magento/PageBuilder/Model/Stage/HtmlFilter.php

Line 118 in 1a52ef4

return $innerHTML;

[Shivam7-1]

Hii @engcom-Hotel Thanks For Reviewing Yes done this changes

[engcom-Hotel]

Also please help us with the purpose of this PR. In the actual codebase we are not using the innerHTML property, here $innerHTML is used as a variable. So this change doesn’t make any sense to me.

Please correct me if I am wrong.

[engcom-Hotel]

Also please help us with the purpose of this PR. In the actual codebase we are not using the innerHTML property, here $innerHTML is used as a variable. So this change doesn’t make any sense to me.

Please correct me if I am wrong.

[Shivam7-1]

Hii @engcom-Hotel Thank you for the feedback. You’re correct that $innerHTML is just a variable and not the innerHTML property. I got Confused here by the name so it's not required here I think

[engcom-Hotel]

Thanks @Shivam7-1, We are closing this PR as per your last comment.

Hii @engcom-Hotel Thank you for the feedback. You’re correct that $innerHTML is just a variable and not the innerHTML property. I got Confused here by the name so it's not required here I think