From 1f9766c97d71fa67b10c21aeb558891f91f83ff2 Mon Sep 17 00:00:00 2001
From: TuNa <ladiesman9x@gmail.com>
Date: Mon, 26 Oct 2020 07:15:15 +0700
Subject: [PATCH] Fix minisearch not appear when disable suggestions search

update
---
 .../view/frontend/templates/form.mini.phtml   |  38 ++++---
 .../Search/view/frontend/web/js/form-mini.js  | 100 +++++++++---------
 2 files changed, 72 insertions(+), 66 deletions(-)

diff --git a/app/code/Magento/Search/view/frontend/templates/form.mini.phtml b/app/code/Magento/Search/view/frontend/templates/form.mini.phtml
index 80e720e2c2fe2..34cae80017f7c 100644
--- a/app/code/Magento/Search/view/frontend/templates/form.mini.phtml
+++ b/app/code/Magento/Search/view/frontend/templates/form.mini.phtml
@@ -4,40 +4,32 @@
  * See COPYING.txt for license details.
  */
 
-// phpcs:disable Magento2.Templates.ThisInTemplate.FoundThis
 ?>
 <?php
 /** @var $block \Magento\Framework\View\Element\Template */
 /** @var $helper \Magento\Search\Helper\Data */
+/** @var $escaper \Magento\Framework\Escaper */
 /** @var $configProvider \Magento\Search\ViewModel\ConfigProvider */
 $helper = $this->helper(\Magento\Search\Helper\Data::class);
 $configProvider = $block->getData('configProvider');
 ?>
 <div class="block block-search">
-    <div class="block block-title"><strong><?= $block->escapeHtml(__('Search')) ?></strong></div>
+    <div class="block block-title"><strong><?= $escaper->escapeHtml(__('Search')) ?></strong></div>
     <div class="block block-content">
         <form class="form minisearch" id="search_mini_form"
-              action="<?= $block->escapeUrl($helper->getResultUrl()) ?>" method="get">
+              action="<?= $escaper->escapeUrl($helper->getResultUrl()) ?>" method="get">
             <div class="field search">
                 <label class="label" for="search" data-role="minisearch-label">
-                    <span><?= $block->escapeHtml(__('Search')) ?></span>
+                    <span><?= $escaper->escapeHtml(__('Search')) ?></span>
                 </label>
                 <div class="control">
                     <input id="search"
-                            <?php if ($configProvider->isSuggestionsAllowed()):?>
-                               data-mage-init='{"quickSearch":{
-                                    "formSelector":"#search_mini_form",
-                                    "url":"<?= $block->escapeUrl($helper->getSuggestUrl())?>",
-                                    "destinationSelector":"#search_autocomplete",
-                                    "minSearchLength":"<?= $block->escapeHtml($helper->getMinQueryLength()) ?>"}
-                               }'
-                            <?php endif;?>
                            type="text"
-                           name="<?= $block->escapeHtmlAttr($helper->getQueryParamName()) ?>"
+                           name="<?= $escaper->escapeHtmlAttr($helper->getQueryParamName()) ?>"
                            value="<?= /* @noEscape */ $helper->getEscapedQueryText() ?>"
-                           placeholder="<?= $block->escapeHtmlAttr(__('Search entire store here...')) ?>"
+                           placeholder="<?= $escaper->escapeHtmlAttr(__('Search entire store here...')) ?>"
                            class="input-text"
-                           maxlength="<?= $block->escapeHtmlAttr($helper->getMaxQueryLength()) ?>"
+                           maxlength="<?= $escaper->escapeHtmlAttr($helper->getMaxQueryLength()) ?>"
                            role="combobox"
                            aria-haspopup="false"
                            aria-autocomplete="both"
@@ -49,13 +41,25 @@ $configProvider = $block->getData('configProvider');
             </div>
             <div class="actions">
                 <button type="submit"
-                    title="<?= $block->escapeHtml(__('Search')) ?>"
+                    title="<?= $escaper->escapeHtml(__('Search')) ?>"
                     class="action search"
                     aria-label="Search"
                 >
-                    <span><?= $block->escapeHtml(__('Search')) ?></span>
+                    <span><?= $escaper->escapeHtml(__('Search')) ?></span>
                 </button>
             </div>
         </form>
     </div>
 </div>
+<script type="text/x-magento-init">
+{
+    "#search": {
+        "quickSearch": {
+            "formSelector":"#search_mini_form",
+            "url":"<?= ($configProvider->isSuggestionsAllowed()) ? $escaper->escapeUrl($helper->getSuggestUrl()) : '' ?>",
+            "destinationSelector":"#search_autocomplete",
+            "minSearchLength":"<?= $escaper->escapeHtml($helper->getMinQueryLength()) ?>"
+        }
+    }
+}
+</script>
diff --git a/app/code/Magento/Search/view/frontend/web/js/form-mini.js b/app/code/Magento/Search/view/frontend/web/js/form-mini.js
index 9b4c814f73d73..ef0a64f840d4b 100644
--- a/app/code/Magento/Search/view/frontend/web/js/form-mini.js
+++ b/app/code/Magento/Search/view/frontend/web/js/form-mini.js
@@ -300,60 +300,62 @@ define([
 
             if (value.length >= parseInt(this.options.minSearchLength, 10)) {
                 this.submitBtn.disabled = false;
-                $.getJSON(this.options.url, {
-                    q: value
-                }, $.proxy(function (data) {
-                    if (data.length) {
-                        $.each(data, function (index, element) {
-                            var html;
-
-                            element.index = index;
-                            html = template({
-                                data: element
+                if (this.options.url) {
+                    $.getJSON(this.options.url, {
+                        q: value
+                    }, $.proxy(function (data) {
+                        if (data.length) {
+                            $.each(data, function (index, element) {
+                                var html;
+
+                                element.index = index;
+                                html = template({
+                                    data: element
+                                });
+                                dropdown.append(html);
                             });
-                            dropdown.append(html);
-                        });
 
-                        this._resetResponseList(true);
-
-                        this.responseList.indexList = this.autoComplete.html(dropdown)
-                            .css(clonePosition)
-                            .show()
-                            .find(this.options.responseFieldElements + ':visible');
-
-                        this.element.removeAttr('aria-activedescendant');
-
-                        if (this.responseList.indexList.length) {
-                            this._updateAriaHasPopup(true);
+                            this._resetResponseList(true);
+
+                            this.responseList.indexList = this.autoComplete.html(dropdown)
+                                .css(clonePosition)
+                                .show()
+                                .find(this.options.responseFieldElements + ':visible');
+
+                            this.element.removeAttr('aria-activedescendant');
+
+                            if (this.responseList.indexList.length) {
+                                this._updateAriaHasPopup(true);
+                            } else {
+                                this._updateAriaHasPopup(false);
+                            }
+
+                            this.responseList.indexList
+                                .on('click', function (e) {
+                                    this.responseList.selected = $(e.currentTarget);
+                                    this.searchForm.trigger('submit');
+                                }.bind(this))
+                                .on('mouseenter mouseleave', function (e) {
+                                    this.responseList.indexList.removeClass(this.options.selectClass);
+                                    $(e.target).addClass(this.options.selectClass);
+                                    this.responseList.selected = $(e.target);
+                                    this.element.attr('aria-activedescendant', $(e.target).attr('id'));
+                                }.bind(this))
+                                .on('mouseout', function (e) {
+                                    if (!this._getLastElement() &&
+                                        this._getLastElement().hasClass(this.options.selectClass)) {
+                                        $(e.target).removeClass(this.options.selectClass);
+                                        this._resetResponseList(false);
+                                    }
+                                }.bind(this));
                         } else {
+                            this._resetResponseList(true);
+                            this.autoComplete.hide();
                             this._updateAriaHasPopup(false);
+                            this.element.removeAttr('aria-activedescendant');
                         }
-
-                        this.responseList.indexList
-                            .on('click', function (e) {
-                                this.responseList.selected = $(e.currentTarget);
-                                this.searchForm.trigger('submit');
-                            }.bind(this))
-                            .on('mouseenter mouseleave', function (e) {
-                                this.responseList.indexList.removeClass(this.options.selectClass);
-                                $(e.target).addClass(this.options.selectClass);
-                                this.responseList.selected = $(e.target);
-                                this.element.attr('aria-activedescendant', $(e.target).attr('id'));
-                            }.bind(this))
-                            .on('mouseout', function (e) {
-                                if (!this._getLastElement() &&
-                                    this._getLastElement().hasClass(this.options.selectClass)) {
-                                    $(e.target).removeClass(this.options.selectClass);
-                                    this._resetResponseList(false);
-                                }
-                            }.bind(this));
-                    } else {
-                        this._resetResponseList(true);
-                        this.autoComplete.hide();
-                        this._updateAriaHasPopup(false);
-                        this.element.removeAttr('aria-activedescendant');
-                    }
-                }, this));
+                    }, this));
+                }
             } else {
                 this._resetResponseList(true);
                 this.autoComplete.hide();