Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics character encoding issue ( \u0020 ) #13827

Closed
Munszu opened this issue Feb 23, 2018 · 3 comments
Closed

Google Analytics character encoding issue ( \u0020 ) #13827

Munszu opened this issue Feb 23, 2018 · 3 comments

Comments

@Munszu
Copy link

@Munszu Munszu commented Feb 23, 2018

Preconditions

  1. Magento 2.2.2.
  2. PHP 7.0

Steps to reproduce

  1. Set locale to en_GB
  2. Enable Google Analytics tracking on backend
  3. Purchase products on the frontend
  4. Login to Google Analytics
  5. Go to Conversions ->E-Commerce -> Overview

Expected result

  1. Product names showing up correctly

Actual result

  1. Spaces in product names get replaced by their HTML value: \u0020
    https://goo.gl/5EjjZx

Fix found in this error report:
#13350

Edit: /vendor/magento/module-google-analytics/Block/Ga.php
and replace every escapeJs with escapeJsQuote

Result:
https://goo.gl/mb1YU3

@ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Feb 26, 2018

Hi, this issue originally was reported in #13350. I'm closing this issue as duplicate.

@magento-engcom-team
Copy link
Contributor

@magento-engcom-team magento-engcom-team commented Feb 28, 2018

Hi @Munszu. Thank you for your report.
The issue has been fixed in #13844 by @julienanquetil in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.4 release.

@magento-engcom-team
Copy link
Contributor

@magento-engcom-team magento-engcom-team commented Mar 10, 2018

Hi @Munszu. Thank you for your report.
The issue has been fixed in #13907 by @julienanquetil in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants