Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Use in Layered Navigation: Filterable (no results)" not working for Price attribute. #14007

Closed
yogeshsuhagiya opened this issue Mar 8, 2018 · 12 comments
Assignees
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@yogeshsuhagiya
Copy link
Member

yogeshsuhagiya commented Mar 8, 2018

Hello,

I'm trying to set Filterable (no results) for price attribute but it's not working.
There is below note for Use in Layered Navigation setting of product attribute at the backend.
Can be used only with catalog input type Dropdown, Multiple Select and Price.
So I hope it should work for Price attribute too.

Preconditions

  1. Magento 2.2.3
  2. PHP 7.1.15
  3. Apache/2.4.18 (Ubuntu)

Steps to reproduce

  1. Goto: Stores > Attributes > Product
  2. Search price attribute and edit it.
  3. In "Storefront Properties" tab, and set Use in Layered Navigation to Filterable (no results)
  4. Go to category view page.
  5. Apply any other filter like color, size etc except price.

Expected result

  1. All price range links will appear for all values, whether the number of results is zero or greater.

Actual result

  1. Appear only those price range links where the number of results is greater than zero. Other links are removed from layered navigation.

Without applying any filter: https://www.screencast.com/t/PWgwUqEQsWVI
After applying the filter: https://www.screencast.com/t/qj6H5Jq0

Thank you.

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Mar 8, 2018
@magento-engcom-team
Copy link
Contributor

@yogeshks, thank you for your report.
We've acknowledged the issue and added to our backlog.

@ashokramji
Copy link

I am working on this at #dmcdindia

@lewis-dan
Copy link

Hi,
I am working on this Issue.
Thanks,
Dan

@lewis-dan
Copy link

I am working on this at #dmcdindia”

@magento-engcom-team
Copy link
Contributor

@lewis-dan thank you for joining. Please accept team invitation here and self-assign the issue.

@lewis-dan lewis-dan self-assigned this May 19, 2018
@ashokramji ashokramji self-assigned this May 19, 2018
@lewis-dan
Copy link

Hi,
Just need to use the other attribute with "Filterable (No Results)" for both Search and Catalog pages.
Check the following screen shots -
image

Only if there is no Results, then Price Attribute wont visible on Left Hand Layered Navigation.

image

@magento-engcom-team
Copy link
Contributor

Hi @yogeshks
Could you please check the comment above?
Thanks

@yogeshsuhagiya
Copy link
Member Author

yogeshsuhagiya commented May 26, 2018

Hello @magento-engcom-team ,
I agree with @lewis-dan that Filterable (No Results) working for other custom attributes but it's not working for price attribute for which I had opened this issue.

@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@vpodorozh
Copy link
Contributor

vpodorozh commented Nov 2, 2018

Hello @yogeshks - about your expected result from this issue: All price range links will appear for all values, whether the number of results is zero or greater. - I do think that it is not valid expectation.
Reason: the user does not need filters that will return the empty set of products.

However, this comment from magento back office could confuse: Can be used only with catalog input type Yes/No, Dropdown, Multiple Select and Price.
I'll just edit this comment and put a remark about Price attribute.

vpodorozh added a commit to vpodorozh/magento2 that referenced this issue Nov 2, 2018
"Use in Layered Navigation: Filterable (no results)" not working for `Price` attribute.
- adjust comment for "Use in Layered Navigation: Filterable (no results)" property to make it more understandable
vpodorozh added a commit to vpodorozh/magento2 that referenced this issue Nov 2, 2018
"Use in Layered Navigation: Filterable (no results)" not working for `Price` attribute.
- adjust comment for "Use in Layered Navigation: Filterable (no results)" property to make it more understandable

(cherry picked from commit e18df69)
vpodorozh added a commit to vpodorozh/magento2 that referenced this issue Nov 2, 2018
"Use in Layered Navigation: Filterable (no results)" not working for `Price` attribute.
- adjust comment for "Use in Layered Navigation: Filterable (no results)" property to make it more understandable

(cherry picked from commit e18df69)
@magento-engcom-team
Copy link
Contributor

Hi @yogeshks. Thank you for your report.
The issue has been fixed in #19044 by @vpodorozh in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 7, 2018
@sidolov
Copy link
Contributor

sidolov commented Nov 8, 2018

Hi @yogeshks. Thank you for your report.
The issue has been fixed in #19037 by @vpodorozh in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants