Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Payment Method doesn't uncheck 'My billing and shipping address are the same' #14819

Closed
eduard13 opened this issue Apr 23, 2018 · 5 comments

Comments

@eduard13
Copy link
Contributor

commented Apr 23, 2018

In Magento 2.2.2, 2.2.3 there is no way to get the Magento behavior on My billing and shipping address are the same checkbox when a new custom Offline Payment Method is used.

Preconditions

  1. Magento 2.2.3 EE (on Magento 2.2.2 CE as well)
  2. PHP 7.1

Steps to reproduce

  1. Create an offline payment method
  2. Add a product to cart
  3. Go to Checkout
  4. Fill in the shipping address
  5. Go to Payment Step
  6. We have our new payment method, and one more - Checkmo
  7. Select Checkmo
  8. Under Selected Payment Method - My billing and shipping address are the same is checked and below we have the billing address = shipping address
    4d0833cc22
  9. Go back to shipping step and change some fields
  10. Come back on the Payment Step

Expected result

  1. My billing and shipping address are the same it should be unchecked
    20e4fedd4b

Actual result

  1. My billing and shipping address are the same is checked, but the address information below doesn't reflect the last changes.
    a67191078b

Also noticed that if the Custom Payment Method is marked as Unavailable, then everything works as needed

Thanks.

@engcom-backlog-nazar

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2018

HI @eduard13 thank you for your report.
We've acknowledged the issue and added to our backlog.

@engcom-backlog-nazar engcom-backlog-nazar removed their assignment Jul 12, 2018

@eduard13

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2018

I'm going to work on it.

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2018

Hi @eduard13. Thank you for your report.
The issue has been fixed in #17593 by @eduard13 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2018

Hi @eduard13. Thank you for your report.
The issue has been fixed in #17628 by @jignesh-baldha in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@miteshdhaduk

This comment has been minimized.

Copy link

commented Apr 2, 2019

@jignesh-baldha Thank you for fixing this. It is working properly in Magento 2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.