Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework for PR #16222 . #16393

Conversation

phoenix128
Copy link
Contributor

@phoenix128 phoenix128 commented Jun 25, 2018

Description

When running 'app:config:dump', admin fields get disabled, but clicking save from backend will process them anyway.
This behaivour causes a validation check on empty fields since the admin form fields are disabled and thus validation errors in many cases.

This PR checks when the field is read only and skips its save.

This is a more complete rework for PR #16222 .

Manual testing scenarios

  1. Go to Stores -> Configuration -> General -> Currency Setup
  2. Setup Base Currency, Default Display Currency and Allowed Currencies to whatever you like
  3. Save
  4. Run bin/magento app:config:dump
  5. Go back to admin and refresh the page (fields are disabled).
  6. Click on save
  7. As result no errors should be displayed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

When running 'app:config:dump', admin fields get disabled, but clicking save will process them anyway
This behaivour causes a validation check on empty fields since the admin form fields are disabled.
This commit checks when the field is read only and skips its save.
@magento-engcom-team
Copy link
Contributor

Hi @phoenix128. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@bmxmale
Copy link

bmxmale commented Jun 26, 2018

I have checked your fix. It's working as expected. Thx for fast response 👍

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@orlangur orlangur self-assigned this Jun 26, 2018
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop July 4, 2018 06:55
@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop July 4, 2018 06:55
@sidolov sidolov changed the title Rework for PR https://github.com/magento/magento2/pull/16222 . Rework for PR #16222 . Jul 4, 2018
@magento-engcom-team magento-engcom-team merged commit af78c2f into magento:2.2-develop Jul 7, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 7, 2018
@magento-engcom-team
Copy link
Contributor

Hi @phoenix128. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants