Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config backend models are not populated with fieldset data #16712

Closed
mam08ixo opened this issue Jul 11, 2018 · 3 comments
Closed

Config backend models are not populated with fieldset data #16712

mam08ixo opened this issue Jul 11, 2018 · 3 comments
Labels
Component: Config Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@mam08ixo
Copy link

mam08ixo commented Jul 11, 2018

In config backend models, it was possible to access all configured values from the current group. This is especially important for performing sanity checks/validation of config value combinations. A recent commit (faint suspicion: 4af80a2) broke that. All config values that are processed after the current field can no longer be accessed via \Magento\Framework\App\Config\Value::getFieldsetDataValue.

Preconditions

  1. Magento 2.2.6-dev

Steps to reproduce

  1. Log in to admin panel
  2. Navigate to Stores → Configuration → Catalog → Catalog → Search Engine Optimization (in fact, every config field with backend model is affected but this one illustrates the problem quite well).
  3. Enter some values in this group's config fields
  4. Save Config
  5. In \Magento\Config\Model\Config::_processGroup monitor the data passed into $backendModel->addData($data)

Expected result

  1. All config values of the current group are passed to the backend model:

expected

Actual result

  1. Only the config values up to the current field are passed to the backend model:

actual

@magento-engcom-team
Copy link
Contributor

Hi @mam08ixo. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@mam08ixo do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 11, 2018
@engcom-backlog-nickolas engcom-backlog-nickolas added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Config Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Jul 19, 2018
@engcom-backlog-nickolas

Hello @mam08ixo, thank you for your report.
We've acknowledged the issue and added to our backlog.

@engcom-backlog-nickolas engcom-backlog-nickolas removed their assignment Jul 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mam08ixo
We are closing this ticket now, as this issue is already fixed with the following commits in 2.2-develop: 86b5bc0 7415171
Fix is expected to be delivered with patch 2.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Config Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

3 participants