Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.3.0 can't change text area field height admin form using Ui component #22771

Closed
Patelcc opened this issue May 7, 2019 · 9 comments
Closed

Comments

@Patelcc
Copy link

@Patelcc Patelcc commented May 7, 2019

Preconditions (*)

  1. Magento version CE 2.3.0
  2. PHP version 7.1.
  3. Admin area

Steps to reproduce (*)

  1. Create admin form usign Ui component.
  2. Add text area field to form
  3. Try to increase text-area field height using <item name="rows" xsi:type="number">60</item>
    Note: It is not working because of CSS admin__control-textarea class given height height: 8.48rem; if you remove this CSS then it is working fine.

Expected result (*)

expected-result

Actual result (*)

Actual-result

@m2-assistant

This comment has been minimized.

Copy link

@m2-assistant m2-assistant bot commented May 7, 2019

Hi @Patelcc. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Patelcc do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no
@arnoudhgz

This comment has been minimized.

Copy link
Contributor

@arnoudhgz arnoudhgz commented May 7, 2019

@magento-engcom-team give me 2.3.1 instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

@magento-engcom-team magento-engcom-team commented May 7, 2019

Hi @arnoudhgz. Thank you for your request. I'm working on Magento 2.3.1 instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

@magento-engcom-team magento-engcom-team commented May 7, 2019

Hi @arnoudhgz, here is your Magento instance.
Admin access: https://i-22771-2-3-1.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@shikhamis11 shikhamis11 self-assigned this May 7, 2019
@m2-assistant

This comment has been minimized.

Copy link

@m2-assistant m2-assistant bot commented May 7, 2019

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

@magento-engcom-team magento-engcom-team commented May 7, 2019

Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99595, MAGETWO-99596 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@serhiyzhovnir serhiyzhovnir self-assigned this May 8, 2019
@m2-assistant

This comment has been minimized.

Copy link

@m2-assistant m2-assistant bot commented May 8, 2019

Hi @serhiyzhovnir. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-backlog m2-backlog bot moved this from Ready for Dev to Dev in Progress in Community Backlog May 8, 2019
serhiyzhovnir added a commit to serhiyzhovnir/magento2 that referenced this issue May 8, 2019
@m2-backlog m2-backlog bot moved this from Dev in Progress to PR In Progress in Community Backlog May 8, 2019
serhiyzhovnir added a commit to serhiyzhovnir/magento2 that referenced this issue May 8, 2019
magento-engcom-team added a commit to okorshenko/magento2 that referenced this issue May 14, 2019
…agento#22779

 - Merge Pull Request magento#22779 from serhiyzhovnir/magento2:issue-22771-remove-hardcoded-height-for-admin-textarea
 - Merged commits:
   1. b630601
   2. d592f06
   3. 79bb992
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this issue May 14, 2019
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

@magento-engcom-team magento-engcom-team commented Jun 4, 2019

Hi @Patelcc. Thank you for your report.
The issue has been fixed in #22783 by @serhiyzhovnir in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

@m2-backlog m2-backlog bot moved this from PR In Progress to Done (last 30 days) in Community Backlog Jun 4, 2019
@Patelcc

This comment has been minimized.

Copy link
Author

@Patelcc Patelcc commented Jun 11, 2019

@magento-engcom-team thanks for the update it will be available upcoming 2.2.10 but this issue is also reproduced in 2.3.X and while report issue I was mentioned version 2.3.0 so i think it should be open. for Magento 2.3.X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.