Refund for bundle product without receiving product back

[simonmaass]

Preconditions (*)

1. 2.3.1
2. php7.2

Steps to reproduce (*)

1. Create bundle product with at least 2 products
2. Create order with bundle product (eg. 50€)
3. Invoice Order
4. Shop Order
5. Create Credit Memo without taking the product back in stock and only refund amount (eg. 10€)
   

Expected result (*)

1. Credit Memo for amount 10€ created

Actual result (*)

1. Error: "The most money available to refund is €xx.xx.
   Eventhou the refund was below the mentioned amount!!!

[m2-assistant]

Hi @simonmaass. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@simonmaass do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[simonmaass]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @simonmaass. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @simonmaass, here is your Magento instance.
Admin access: https://i-23440-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-17848, MC-17849 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[mwr]

The root cause of the Problem seems to be in \Magento\Sales\Model\Order\CreditmemoFactory::createByOrder.

public function createByOrder(\Magento\Sales\Model\Order $order, array $data = [])
    {
        $totalQty = 0;
        $creditmemo = $this->convertor->toCreditmemo($order);
        $qtyList = isset($data['qtys']) ? $data['qtys'] : [];

        foreach ($order->getAllItems() as $orderItem) {
            if (!$this->canRefundItem($orderItem, $qtyList)) {
                continue;
            }

            $item = $this->convertor->itemToCreditmemoItem($orderItem);
            $qty = $this->getQtyToRefund($orderItem, $qtyList);
            $totalQty += $qty;
            $item->setQty($qty);
            $creditmemo->addItem($item);
        }

        $creditmemo->setTotalQty($totalQty);

        $this->initData($creditmemo, $data);

        $creditmemo->collectTotals();
        return $creditmemo;
    }

Either canRefundItem should return false but does not or getQtyToRefund should return 0 but does not either.

I have tried fixing it with a check of the qtyList containing an empty array in this scenario (bundle with 0 items refunded).

            if (!array_key_exists($orderItem->getId(), $qtyList)) {
                $qty = 0;
            }

This works fine except when there is one product of a bundle being refunded. Then the Items are not rendered when viewing the creditmemo. Most likely because the parent product of the bundled item is missing.
At this point I am not sure how the intended workflow is for bundles on a creditmemo.

Additionaly the method \Magento\Sales\Model\Order\CreditmemoFactory::createByOrder seems to be used multiple times: when the form is generated, when the Update Qty Button is clicked and when the creditmemo is saved.

[simonmaass]

any update on this? This is rather important for us because we are often refunding money but not taking the product back

[DavidLambauer]

Ping

[m2-assistant]

Hi @KiuNguyen. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[magento-engcom-team]

Hi @simonmaass. Thank you for your report.
The issue has been fixed in #27455 by @KiuNguyen in 2.4-develop branch
Related commit(s):

• d0ab2a328666825dc1f87f333638255268a24026
• d03d1338b7b05da2faccc5b4dd2ec775bc0c8161
• 4807ebb53158ebdd9207ad994ab38d4084c9d1d2
• b88d88e40ffffd141bed4dd32483148af1ad29fe
• 10d5f735c83c4588c449c85126882e4fb7bfd337
• b13b0ec728c1a06410602e5f018fab5b2d19b847
• 4b28ae32553d37b6bda8b444f8905c8cdddd4054
• 9de9cf0df827d7f1741854ffa1f3f15ff82c711b
• a7ea256e1741716a5ab49345a7aa3d65d493a20d
• df1b766db8fd57689577db98311add9a44274f06
• 84ff07645320eadedee48b9f3ffdab683c59bc9e
• a4d0b7957c14d48a29c704d0e3e11feead6a9ec2

The fix will be available with the upcoming 2.4.0 release.